New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help/Examples: Example image viewer: Toolbar's Up button takes us back to examples for first question. #14

Closed
Dostoi opened this Issue Dec 31, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@Dostoi
Copy link

Dostoi commented Dec 31, 2014

When in the help of the bar/no bar section, clicking on a picture then going back open the first help (smooth, features or disk, star or artefact) instead of the bar/no bar

On version 1.32

@murraycu murraycu self-assigned this Dec 31, 2014

@Dostoi

This comment has been minimized.

Copy link

Dostoi commented Dec 31, 2014

Well I can't recreate the issue any more, so I don't know what happened

@murraycu

This comment has been minimized.

Copy link
Owner

murraycu commented Jan 2, 2015

Thanks for reporting this. I can reproduce it. It only happens when you use the back/up arrow on the app bar at the top. It doesn't happen when you use the regular back button. This is like this bug:
#6

It should be easy enough to fix but I won't have a chance until some time next week.

@murraycu murraycu changed the title Bug with the help Help/Examples: Example image viewer: Toolbar's Up button takes us back to examples for first question. Jan 2, 2015

murraycu added a commit that referenced this issue Jan 8, 2015

ExampleViewerActivity: Make the Toolbar's Up Button go back properly.
Override onOptionsItemSelected() so we can modify the Intent
used with navigateUpTo(), to specify FLAG_ACTVITY_CLEAR, so we
resume the parent activity instead of recreating it, just as if the
user had used the back button - which the user generally cannot
distinguish from the up button anyway.
We could instead have marked the parent activity as singleTop
in the manifest, but it seems nice to keep this parent activity
more flexible.

This should fix this bug:
#14
@murraycu

This comment has been minimized.

Copy link
Owner

murraycu commented Jan 9, 2015

This should be fixed now in version 1.33 which I've just released. Thanks again for reporting it.

@murraycu murraycu closed this Jan 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment