Skip to content
Permalink
Browse files

ar71xx: ag71xx: preserve port mirror flags during swconfig apply

The swconfig load operation always triggers 'apply' function which in
this driver currently clears port mirroring flags effectively undoing
port mirroring configuration.

This fix preserves port mirroring flags during apply.

Signed-off-by: Milan Krstic <milan.krstic@gmail.com>
  • Loading branch information...
mkrle authored and jow- committed Jan 20, 2019
1 parent 76a629e commit 39ede7bc67bbb54ae1645fba9f6b7a2bcc9b8c0f
Showing with 4 additions and 0 deletions.
  1. +4 −0 target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c
@@ -730,6 +730,10 @@ static void ar7240sw_setup_port(struct ar7240sw *as, unsigned port, u8 portmask)
portmask = ar7240sw_port_mask(as, AR7240_PORT_CPU);
}

/* preserve mirror rx&tx flags */
ctrl |= ar7240sw_reg_read(mii, AR7240_REG_PORT_CTRL(port)) &
(AR7240_PORT_CTRL_MIRROR_RX | AR7240_PORT_CTRL_MIRROR_TX);

/* allow the port to talk to all other ports, but exclude its
* own ID to prevent frames from being reflected back to the
* port that they came from */

0 comments on commit 39ede7b

Please sign in to comment.
You can’t perform that action at this time.