Skip to content
Permalink
Browse files

cns3xxx: don't use invalid mask value for clock events

According to a commit from kernel 4.18-rc3, it's not valid
to use "cpu_mask_all" for clock events and it should be
replaced in favor of "cpu_possible_mask" [1]

This warning was seen when booting kernel 4.19 on a cns3xxx board.
Let's fix it also here just to be safe.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.19.18&id=fbfa9260085b5b578a049a90135e5c51928c5f7f

Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
  • Loading branch information...
xback committed Jan 28, 2019
1 parent c6bebe1 commit 880a4b334ebc0fc7668343e7feafffa6767d6b08
Showing with 4 additions and 2 deletions.
  1. +4 −2 target/linux/cns3xxx/patches-4.14/090-timers.patch
@@ -17,15 +17,17 @@
writel(reload, cns3xxx_tmr1 + TIMER1_AUTO_RELOAD_OFFSET);
ctrl |= (1 << 0) | (1 << 2) | (1 << 9);
writel(ctrl, cns3xxx_tmr1 + TIMER1_2_CONTROL_OFFSET);
@@ -175,7 +176,7 @@ static struct clock_event_device cns3xxx
@@ -175,8 +176,8 @@ static struct clock_event_device cns3xxx
.set_state_oneshot = cns3xxx_set_oneshot,
.tick_resume = cns3xxx_shutdown,
.set_next_event = cns3xxx_timer_set_next_event,
- .rating = 350,
- .cpumask = cpu_all_mask,
+ .rating = 300,
.cpumask = cpu_all_mask,
+ .cpumask = cpu_possible_mask,
};

static void __init cns3xxx_clockevents_init(unsigned int timer_irq)
@@ -220,6 +221,32 @@ static void __init cns3xxx_init_twd(void
twd_local_timer_register(&cns3xx_twd_local_timer);
}

0 comments on commit 880a4b3

Please sign in to comment.
You can’t perform that action at this time.