Skip to content
Permalink
Browse files

gre: remove setting default firewall zone to wan

There are two problems with this behaviour that the zone is set to wan
if no zone config option is defined in the interface section.

* The zone for the interface is "normally" specified in the firewall
config file. So if we have defined "no" zone for this interface zone
option is set now to "wan" additonaly if we add the interface in the firewall
config section to the "lan" zone, the interface is added to lan and wan at once.

iptables-save | grep <iface>

This is not what I expect.

* If I do not want to set a zone to this interface it is not possible.

Remove the default assigment to wan if no zone option is defined.
If some one need the option it stil possible to define this option.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [PKG_RELEASE increase]
  • Loading branch information...
feckert authored and dedeckeh committed Oct 11, 2018
1 parent 5fd68d6 commit bdedb798150a58ad7ce3c4741f2f31df97e84c3f
Showing with 1 addition and 2 deletions.
  1. +1 −1 package/network/config/gre/Makefile
  2. +0 −1 package/network/config/gre/files/gre.sh
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=gre
PKG_VERSION:=1
PKG_RELEASE:=9
PKG_RELEASE:=10
PKG_LICENSE:=GPL-2.0

include $(INCLUDE_DIR)/package.mk
@@ -16,7 +16,6 @@ gre_generic_setup() {
local mtu ttl tos zone ikey okey icsum ocsum iseqno oseqno multicast
json_get_vars mtu ttl tos zone ikey okey icsum ocsum iseqno oseqno multicast

[ -z "$zone" ] && zone="wan"
[ -z "$multicast" ] && multicast=1

proto_init_update "$link" 1

0 comments on commit bdedb79

Please sign in to comment.
You can’t perform that action at this time.