Skip to content
Permalink
Browse files

base-files: config_get: prevent filename globbing

When config_get is called as "config_get section option" the option
is unexpectedly globbed by the shell which differs from the way options
are read to a variable with "config_get variable section option".
Add another layer of double quotes to fix it.

Signed-off-by: Günther Kelleter <guenther.kelleter@devolo.de>
  • Loading branch information...
dvlemplgk authored and jow- committed Oct 8, 2018
1 parent 37e9186 commit c3389ab135400fba0cb710d9c6c63df2f563d9d9
Showing with 2 additions and 2 deletions.
  1. +1 −1 package/base-files/Makefile
  2. +1 −1 package/base-files/files/lib/functions.sh
@@ -12,7 +12,7 @@ include $(INCLUDE_DIR)/version.mk
include $(INCLUDE_DIR)/feeds.mk

PKG_NAME:=base-files
PKG_RELEASE:=196
PKG_RELEASE:=197
PKG_FLAGS:=nonshared

PKG_FILE_DEPENDS:=$(PLATFORM_DIR)/ $(GENERIC_PLATFORM_DIR)/base-files/
@@ -92,7 +92,7 @@ config_unset() {
# config_get <section> <option>
config_get() {
case "$3" in
"") eval echo "\${CONFIG_${1}_${2}:-\${4}}";;
"") eval echo "\"\${CONFIG_${1}_${2}:-\${4}}\"";;
*) eval export ${NO_EXPORT:+-n} -- "${1}=\${CONFIG_${2}_${3}:-\${4}}";;
esac
}

0 comments on commit c3389ab

Please sign in to comment.
You can’t perform that action at this time.