Skip to content

Commit

Permalink
fix black up/down arrow icons in dark theme
Browse files Browse the repository at this point in the history
  • Loading branch information
anatoly-os committed Jun 21, 2019
1 parent 15b91e4 commit 17d9c99
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 1 deletion.
3 changes: 3 additions & 0 deletions fluid/fluidgui.cpp
Expand Up @@ -124,6 +124,9 @@ FluidGui::FluidGui(Synthesizer* s)
connect(_progressTimer, SIGNAL(timeout()), this, SLOT(updateProgress()));
connect(soundFonts, SIGNAL(itemSelectionChanged()), this, SLOT(updateUpDownButtons()));

soundFontUp->setIcon(*icons[int(Icons::arrowUp_ICON)]);
soundFontDown->setIcon(*icons[int(Icons::arrowDown_ICON)]);

//update sfs
QStringList sfonts = fluid()->soundFonts();
soundFonts->clear();
Expand Down
3 changes: 3 additions & 0 deletions mscore/editstaff.cpp
Expand Up @@ -73,6 +73,9 @@ EditStaff::EditStaff(Staff* s, const Fraction& /*tick*/, QWidget* parent)
connect(nextButton, SIGNAL(clicked()), SLOT(gotoNextStaff()));
connect(previousButton, SIGNAL(clicked()), SLOT(gotoPreviousStaff()));

nextButton->setIcon(*icons[int(Icons::arrowUp_ICON)]);
previousButton->setIcon(*icons[int(Icons::arrowDown_ICON)]);

addAction(getAction("help")); // why is this needed?
}

Expand Down
3 changes: 3 additions & 0 deletions mscore/excerptsdialog.cpp
Expand Up @@ -134,6 +134,9 @@ ExcerptsDialog::ExcerptsDialog(MasterScore* s, QWidget* parent)
SLOT(addButtonClicked()));
connect(title, SIGNAL(textChanged(const QString&)), SLOT(titleChanged(const QString&)));

moveUpButton->setIcon(*icons[int(Icons::arrowUp_ICON)]);
moveDownButton->setIcon(*icons[int(Icons::arrowDown_ICON)]);

for (int i = 1; i <= VOICES; i++) {
//partList->model()->setHeaderData(i, Qt::Horizontal, MScore::selectColor[i-1], Qt::BackgroundRole);
partList->header()->resizeSection(i, 30);
Expand Down
4 changes: 3 additions & 1 deletion mscore/importmidi/importmidi_panel.cpp
Expand Up @@ -8,7 +8,7 @@
#include "mscore/preferences.h"
#include "musescore.h"
#include "libmscore/score.h"

#include "icons.h"

namespace Ms {

Expand Down Expand Up @@ -128,6 +128,8 @@ void ImportMidiPanel::setupUi()
connect(_ui->pushButtonDown, SIGNAL(clicked()), SLOT(moveTrackDown()));
connect(_ui->toolButtonHideMidiPanel, SIGNAL(clicked()), SLOT(hidePanel()));

_ui->pushButtonDown->setIcon(*icons[int(Icons::arrowDown_ICON)]);

_updateUiTimer->start(100);
updateUi();
_ui->tracksView->setVHeaderDefaultSectionSize(24);
Expand Down
3 changes: 3 additions & 0 deletions mscore/instrwidget.cpp
Expand Up @@ -385,6 +385,9 @@ InstrumentsWidget::InstrumentsWidget(QWidget* parent)
downButton->setEnabled(false);
addStaffButton->setEnabled(false);
addLinkedStaffButton->setEnabled(false);

upButton->setIcon(*icons[int(Icons::arrowUp_ICON)]);
downButton->setIcon(*icons[int(Icons::arrowDown_ICON)]);

instrumentSearch->setFilterableView(instrumentList);
}
Expand Down
4 changes: 4 additions & 0 deletions mscore/toolbarEditor.cpp
Expand Up @@ -13,6 +13,7 @@
#include "toolbarEditor.h"
#include "musescore.h"
#include "workspace.h"
#include "icons.h"

namespace Ms {

Expand Down Expand Up @@ -60,6 +61,9 @@ ToolbarEditor::ToolbarEditor(QWidget* parent)
connect(up, SIGNAL(clicked()), SLOT(upAction()));
connect(down, SIGNAL(clicked()), SLOT(downAction()));
connect(buttonBox, SIGNAL(accepted()), SLOT(accepted()));

up->setIcon(*icons[int(Icons::arrowUp_ICON)]);
down->setIcon(*icons[int(Icons::arrowDown_ICON)]);

MuseScore::restoreGeometry(this);
}
Expand Down
5 changes: 5 additions & 0 deletions zerberus/zerberusgui.cpp
Expand Up @@ -14,6 +14,7 @@

#include "mscore/preferences.h"
#include "mscore/extension.h"
#include "mscore/icons.h"

//---------------------------------------------------------
// SfzListDialog
Expand Down Expand Up @@ -106,6 +107,10 @@ ZerberusGui::ZerberusGui(Ms::Synthesizer* s)
_progressTimer = new QTimer(this);
connect(_progressTimer, SIGNAL(timeout()), this, SLOT(updateProgress()));
connect(files, SIGNAL(itemSelectionChanged()), this, SLOT(updateButtons()));

soundFontUp->setIcon(*Ms::icons[int(Ms::Icons::arrowUp_ICON)]);
soundFontDown->setIcon(*Ms::icons[int(Ms::Icons::arrowDown_ICON)]);

updateButtons();
}

Expand Down

0 comments on commit 17d9c99

Please sign in to comment.