From 34c65c6276db065372306b77e4c73529db7c644a Mon Sep 17 00:00:00 2001 From: Casper Jeukendrup <48658420+cbjeukendrup@users.noreply.github.com> Date: Mon, 25 Sep 2023 01:55:12 +0200 Subject: [PATCH] Code review fixes - a few more small ones --- src/engraving/dom/edit.cpp | 6 +----- src/engraving/dom/engravingitem.cpp | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/engraving/dom/edit.cpp b/src/engraving/dom/edit.cpp index 2cf5dc4406172..10dcafa1772c6 100644 --- a/src/engraving/dom/edit.cpp +++ b/src/engraving/dom/edit.cpp @@ -4035,11 +4035,7 @@ MeasureBase* Score::insertMeasure(ElementType type, MeasureBase* beforeMeasure, MeasureBase* newMeasureBase = toMeasureBase(Factory::createItem(type, score->dummy())); newMeasureBase->setTick(tick); - if (dontCloneFrameToParts) { - newMeasureBase->setExcludeFromOtherParts(true); - } else { - newMeasureBase->setExcludeFromOtherParts(false); - } + newMeasureBase->setExcludeFromOtherParts(dontCloneFrameToParts); if (score == this) { result = newMeasureBase; diff --git a/src/engraving/dom/engravingitem.cpp b/src/engraving/dom/engravingitem.cpp index ade8c5e444c7e..8552bab77a758 100644 --- a/src/engraving/dom/engravingitem.cpp +++ b/src/engraving/dom/engravingitem.cpp @@ -1308,7 +1308,7 @@ PropertyPropagation EngravingItem::propertyPropagation(EngravingItem* destinatio Score* destinationScore = destinationItem->score(); bool isTextProperty = mu::contains(textProperties(), propertyId); - if (isTextProperty && isPropertyLinkedToMaster(propertyId) || sourceScore == destinationScore) { + if ((isTextProperty && isPropertyLinkedToMaster(propertyId)) || sourceScore == destinationScore) { return PropertyPropagation::PROPAGATE; }