Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix #269845 Svg don't inheirt QPaintEnginePrivate
SvgPaintEnginePrivate class has always extended QPaintEnginePrivate. But QPaintEnginePrivate was defined in a header file which was copy-and-pasted from Qt over 6 years ago in the initial git commit. But with 5.10, Qt added another QRegion member to their definition of QPaintEnginePrivate to fix a bug, so the old copy-and-pasted header no longer correctly represents QPaintEnginePrivate. This conflicting definition results in a segfault whenever I tried to run mscore 2.1, 2.2, or master at least on my armv7 arch linux machine when using Qt 5.10 (although worked with Qt 5.9). Lasconic suggested maybe try removing the inheiritance all together. Turns out SvgPaintEnginePrivate doesn't actually need to inheirit QPaintEnginePrivate. So the fix here is to remove that inheiritance and complety remove the old copy-and-pasted private header file.
- Loading branch information