New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning channels #1083

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
3 participants
@Igevorse
Contributor

Igevorse commented Jul 31, 2014

CLOSED, see http://dev-list.musescore.org/GSoC-2015-Improving-MIDI-channels-MIDI-Actions-td7579312.html
I can resolve merge conflicts only after merging PR #1171
Please don't merge this commit now. I'll test it hard. Hope, other people will help me.
Assigning channels to staves gives better control over connecting to external synthesizers and saving midi/musicxml files.
The key object here is score->midiMapping that contains our mapping (channel (is Channel_) - > midi port, midi channel).
Instruments can have the same midi port/channel, but anyway they have different channels (Channel_ ). That's why mapping has almost no effect on the internal synth (fluid.cpp does not use score->midiMapping).
Also since we can choose ports, there is no need in "Ports: " spinbox in Preferences->I/O. Now we update number of JACK/ALSA MIDI ports automatically when MuseScore does really need it.
Volume, pan, etc. controls (in mixer window) of the Instruments with the same ports and channel are synced, because we can't have different global parameters for a one midi channel. (Ok, we can by sending messages about global volume,pan, etc before every note, but external sequencer can die :(. )
More information about how it works:
http://igevorse.lited.net/p16.html
http://igevorse.lited.net/p17.html

@Jojo-Schmitz

This comment has been minimized.

Show comment
Hide comment
@Jojo-Schmitz

Jojo-Schmitz Dec 22, 2014

Contributor

PR #1171 is merged ;-)

Contributor

Jojo-Schmitz commented Dec 22, 2014

PR #1171 is merged ;-)

@Igevorse

This comment has been minimized.

Show comment
Hide comment
@Igevorse

Igevorse Dec 22, 2014

Contributor

@Jojo-Schmitz Yes, I'm just waiting for my exams to finish.

Contributor

Igevorse commented Dec 22, 2014

@Jojo-Schmitz Yes, I'm just waiting for my exams to finish.

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Feb 10, 2015

Hi, musescore is now in beta 2 state and I wonder if there are some chances this PR will be in the next release ?

Hi, musescore is now in beta 2 state and I wonder if there are some chances this PR will be in the next release ?

@Igevorse

This comment has been minimized.

Show comment
Hide comment
@Igevorse

Igevorse Feb 12, 2015

Contributor

@daeavelwyn
Hi, there were a lot of changes in MuseScore, so unfortunately, I have to rewrite some places of code (it's not enough to remove merge conflicts). It will take some time, and since te date of release of MuseScore 2.0 is still not set, there are chances this PR will be in the next release.

Contributor

Igevorse commented Feb 12, 2015

@daeavelwyn
Hi, there were a lot of changes in MuseScore, so unfortunately, I have to rewrite some places of code (it's not enough to remove merge conflicts). It will take some time, and since te date of release of MuseScore 2.0 is still not set, there are chances this PR will be in the next release.

@Igevorse Igevorse closed this Feb 12, 2015

@Igevorse Igevorse reopened this Feb 12, 2015

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Feb 12, 2015

@Igevorse ok, and do you need help for testing ? As i'm waiting for this option that will let me use musescore as a master piece of my workflow, I would be glade to help :)

@Igevorse ok, and do you need help for testing ? As i'm waiting for this option that will let me use musescore as a master piece of my workflow, I would be glade to help :)

@Igevorse

This comment has been minimized.

Show comment
Hide comment
@Igevorse

Igevorse Feb 12, 2015

Contributor

@daeavelwyn yes, the PR should be tested well before merging. It would be cool if you could help with testing.

Contributor

Igevorse commented Feb 12, 2015

@daeavelwyn yes, the PR should be tested well before merging. It would be cool if you could help with testing.

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Feb 13, 2015

@Igevorse could you explain me how to merge your work in the last musescore code as I could benefit from last musescore code AND from your work ?

@Igevorse could you explain me how to merge your work in the last musescore code as I could benefit from last musescore code AND from your work ?

@Igevorse

This comment has been minimized.

Show comment
Hide comment
@Igevorse

Igevorse Feb 15, 2015

Contributor

@daeavelwyn it's impossible for now.
When new PR is released, you will need just to switch to my branch to get all benefits.

Contributor

Igevorse commented Feb 15, 2015

@daeavelwyn it's impossible for now.
When new PR is released, you will need just to switch to my branch to get all benefits.

@Igevorse Igevorse closed this Jun 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment