Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #40171: Crash in ~ScoreView() fixed #1484

Merged
merged 1 commit into from Dec 1, 2014

Conversation

Igevorse
Copy link
Contributor

No description provided.

@lasconic
Copy link
Contributor

I'm not fan of this new flag...
seq->recomputeMaxMidiOutPort(); in the ScoreView destructor is not a good idea in the first place
We should find a better place to do that.

@@ -4260,6 +4260,8 @@ void MuseScore::updatePlayMode()

void MuseScore::closeScore(Score* score)
{
// Let's compute maximum count of ports in remaining scores
seq->recomputeMaxMidiOutPort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seq can't be null ?

lasconic added a commit that referenced this pull request Dec 1, 2014
fix #40171: Crash in ~ScoreView() fixed
@lasconic lasconic merged commit f4f19e9 into musescore:master Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants