fix #40581: overlapping ledger lines between voices #1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix aims for a balance betwene efficiency and effectiveness. In determining if there is a conflict with a previous note, I always prefer a note in the same voice if there is one in the previous segment. Only if there isn't do I look in other voices. I tried variations where I always hunted for chord with ledger lines in any voice, but there would still be corner cases that were missed, so I went with the simple version.