Fix #19374 #153
Fix #19374 #153
Conversation
| //--------------------------------------------------------- | ||
|
|
||
| qreal Note::headWidth() const | ||
| qreal Note::headWidth(StaffTypeTablature* tab) const |
There was a problem hiding this comment.
Probably a naive question, but is there no way to get the StaffType from the note instead of passing it and then detect if the stafftype is a tablature and do things accordingly? The signature of the method just feel weird from the outside.
|
This was my original idea, but sometime the 'real' fret mark width is needed and sometime the 'abstract' (= as pitched) width is needed for alignment or centering purposes. If you look, you see that the method is called sometime with and sometime without the parameter. It would be possible to pass a boolean (actual vs. abstract) but I indulged in a bit of optimization, as the StaffTypeTablature* is already known in all the cases when it is needed, rather than climb the whole ladder note -> track -> staff -> stafftype for each note. It would also be possible to add entirely new methods for tabs: Note::tabHeadWidth(StaffTypeTablature_) and Note::tabheadHeight(StaffTypeTablature_); but I would pass the parameter anyway. |
…TAB's from generic Note::headWidth() and Note::headHeight()
Fix #19374
Wide (two-digit) numbers in TAB collide; fixed
See: http://musescore.org/en/node/19374