Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12791: Num pad not responding for duration selection #15819

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Eism
Copy link
Contributor

@Eism Eism commented Jan 11, 2023

Resolves: #12791
Resolves: #12956
Resolves: #15204
Resolves: #14505

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 11, 2023

Could you add NumPad + Enter as an additional shortcut for System Break?
Would fix #12956

And NumPad + dot for dotted duration?
And maybe NumPad ++/- for sharp/flat?

Maybe NumPad + / and NumPad + * for half and double duration

@Eism
Copy link
Contributor Author

Eism commented Jan 11, 2023

@Jojo-Schmitz thanks, makes sense for
And NumPad + dot for dotted duration?
And maybe NumPad ++/- for sharp/flat?
Maybe NumPad + /

Did not find a sequence *

@Jojo-Schmitz
Copy link
Contributor

Double/half duration, W and Q. Also with Shift

@Eism
Copy link
Contributor Author

Eism commented Jan 11, 2023

Why we should use NumPad+/ and NumPad+* for half and double duration?

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 11, 2023

Why we should use NumPad+/ and NumPad+* for half and double duration?

Because those are otherwise unused? I'm open for better suggestions though. Not using them at all seems a waste.
Maybe acciaccatura/appoggiatura? Might even be better.

OTH instead of flat/sharp I'd rather have NumPad + for Tie, maybe Numpad + - for Slur? Would allow easy note entry with one hand on Numpad and the other on mouse, excatly my favourite workflow

@Eism
Copy link
Contributor Author

Eism commented Jan 11, 2023

For other changes please create a separate issue

@Jojo-Schmitz
Copy link
Contributor

Tested: durations (1-9) work, /, +, - and Enter works, but . (resp. , in my case) does not,
Windows 11, German QWERTZ keyboard, German language settings

Changing to

    <SC>
        <key>pad-dot</key>
        <seq>.</seq>
        <seq>Num+.</seq>
        <seq>Num+,</seq>
    </SC>

makes 'dot' work for me. Needed for all of continental Europe as far as I can tell

NumPad+0 doesn't work for Rest

    <SC>
        <key>rest</key>
        <seq>0</seq>
        <seq>Num+0</seq>
    </SC>

fixes that. Both are vital shortcuts that did work in MU3 out of the box

So we're almost there ;-)

@Jojo-Schmitz
Copy link
Contributor

Great! Now Mac and AZERTY users would need to test I guess

@Jojo-Schmitz
Copy link
Contributor

Darn, that dreaded spurious unit test failure again...

@vpereverzev vpereverzev merged commit a6d1f79 into musescore:master Jan 12, 2023
@Eism Eism deleted the shortcuts_numpad_fix branch January 12, 2023 12:38
@Flying-Roger
Copy link

See my recent post on #15204:

I noticed that there is a discrepancy between the way detects the numeric keypad while editing a score with respect to what it does while defining shortcuts:

while defining a shortcut, pressing 0 on the alphanumerical keyboard or pressing 0 on the numeric keypad has exactly the same effect: "0" is recorded for the shortcut.
while editing a score, pressing 0 on the alphanumerical keyboard does what is defined as "0" in the shortcut xml file, while pressing 0 on the numeric keypath does is not detected as "0", but as "Num+0", thereby requiring a specific definition in the shortcut xml file.
This is a bug : the consequence is that it is impossible to define a shortcut on the numerical keypad via the shortcut definition menu. The workaround is to export the shortcuts in xml, edit the xml to add the Num+x definitions and reimport the xml file.
I see that this topic is noted as "fixed", but I recommend to make sure that the root cause reported here above is also fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants