Fix for #8964: Properties Panel empty when no score open

[AnnikaLevesque]

Resolves: #8964

In response to #8964 (comment), the modules in the Properties Panel that have no effect when no score is open will no longer appear when no score is open. They will appear when a score is opened and nothing is selected, and disappear again if (all) score(s) are closed.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

I built RUN_TESTS, and the only failing tests seemed to be unrelated ones, such as audio tests and braille tests.

[AnnikaLevesque]

I can't figure out how to run uncrustify, any help would be appreciated with that (or just let me know what the style issue is)

[Jojo-Schmitz]

You don't really need to run uncrustify yourself, just make the code changes proposed by the codestyle check

diff --git a/src/inspector/models/inspectorlistmodel.cpp b/src/inspector/models/inspectorlistmodel.cpp
index 82ab4bc..68d80f2 100644
--- a/src/inspector/models/inspectorlistmodel.cpp
+++ b/src/inspector/models/inspectorlistmodel.cpp
@@ -70,7 +70,7 @@ void InspectorListModel::buildModelsForEmptySelection()
         removeUnusedModels({}, false /*isRangeSelection*/);
         return;
     }
-    
+
     removeUnusedModels({}, false /*isRangeSelection*/, persistentSectionList);
 
     createModelsBySectionType(persistentSectionList);

It basically is a tab or a couple spaces too much

[Eism]

Also please squash two commits about codestayle into other commits where you did these changes

[AnnikaLevesque]

Thank you for taking a look at it! I'm currently travelling, will fix when I get back to my computer.

[DmitryArefiev]

@zacjansheski Hi! Can you test this on Mac and Win please?

[zacjansheski]

Testing on Mac OS. Please check that the "eyes" under "visible" are not affected by this change.

Screen shot attached showing property window on new score:
PR - on the left. (all eyes are closed)
4.0.2 - on the right

[AnnikaLevesque]

It seems that the "Invisible", "Formatting", and "Frames" eyes have behavior that is the opposite of what is expected (those elements become visible when the eye icon is closed and vice versa), but I don't know why this is the case. If I select something on the score and return to empty selection, the eye icons go back to behaving normally. If I close the score and reopen a new one, they are wrong again.

Is there something unique that happens when these panels are populated for the first time or when they are populated with no score? Is the "Page margins" eye different? I don't know why that one seems to work when the others don't.

[zacjansheski]

It's notable that when the properties panel is visible in the nightly (with no score opened), all eyes are shut, so I think you are correct in seeing there is change happening here when a score is opened (all but "Page Margins" are flipped to open)

[AnnikaLevesque]

Re: the last commit, I'm guessing that when a new score is opened (or the panel is created for the first time), each "model" in the properties panel is created with the constructor, but subsequent uses of the model just updates it instead of creating a new one. This doesn't explain why it works properly on the nightly build though, so I think I'm still missing something.

[ghost]

@AnnikaLevesque Could you please rebase this PR? That may (should) solve the mysterious failing vtests.

[zacjansheski]

Tested on MacOS 11.6.5, Ubuntu 20.04.6 LTS, and Windows 11. Works well!