New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning MIDI port/channel to instruments [ready to merge] #2126

Merged
merged 14 commits into from Oct 28, 2015

Conversation

Projects
None yet
@Igevorse
Contributor

Igevorse commented Jul 15, 2015

Here's a feature that allows to assign any MIDI port/channel to an instrument in Mixer.
It was proposed many times starting from 2011 or even earlier.
This is a part of my work in Google Summer of Code 2015.

New opportunities unlocked:

  • Assign each instrument to a different MIDI port and connect MuseScore to external synthesizers, effects processor and VST instruments via JACK with minimum additional software (JACK + MuseScore + QJackCtl/any patchbay).
    Example of assigning different MIDI ports to instruments
  • Export MIDI mapping to MusicXML and MIDI files to make futher editing/processing simpler.
  • Better control of MuseScore output for research/related projects (MuseScoreSSMN, etc).
  • Your use case here

Changes in file format:

Tags midiPort and midiChannel are written if necessary.

Changes in UI:

  • MIDI port and channel spin boxes in Mixer
  • "Show Midi controls in Mixer" checkbox in Preferences->Score

Backward compatibility:

Yes

Import MIDI mapping:

MusicXML, Guitar Pro files

Export MIDI mapping:

MusicXML, MIDI files

Animation of MIDI port/channel synchronization

Welcome for testing!

@ycollet

This comment has been minimized.

Show comment
Hide comment
@ycollet

ycollet Jul 16, 2015

I vote for this one. I already use this kind of thing with tuxguitar to simulate a multitrack recording.

ycollet commented Jul 16, 2015

I vote for this one. I already use this kind of thing with tuxguitar to simulate a multitrack recording.

@Igevorse Igevorse changed the title from Assigning MIDI port/channel to instruments [testing, don't merge] to Assigning MIDI port/channel to instruments [don't merge, welcome for testing] Jul 16, 2015

@mgavioli

This comment has been minimized.

Show comment
Hide comment
@mgavioli

mgavioli Jul 17, 2015

Contributor

I run a first, rather simple, test and, as far as I can tell, it works correctly for my (simple!) purposes, mainly for driving GrandOrgue.

Then, so far so good! Thank you!

(Do I remember correctly that once upon a time there was the project to enable staff text to send arbitrary MIDI events? Is this still in agenda? Thanks)

Contributor

mgavioli commented Jul 17, 2015

I run a first, rather simple, test and, as far as I can tell, it works correctly for my (simple!) purposes, mainly for driving GrandOrgue.

Then, so far so good! Thank you!

(Do I remember correctly that once upon a time there was the project to enable staff text to send arbitrary MIDI events? Is this still in agenda? Thanks)

@Igevorse

This comment has been minimized.

Show comment
Hide comment
@Igevorse

Igevorse Jul 17, 2015

Contributor

@mgavioli Thanks for the testing!
I will start to work on "MIDI Actions" in a few days.

Contributor

Igevorse commented Jul 17, 2015

@mgavioli Thanks for the testing!
I will start to work on "MIDI Actions" in a few days.

@mgavioli

This comment has been minimized.

Show comment
Hide comment
@mgavioli

mgavioli Jul 17, 2015

Contributor

@Igevorse : Great news! Thanks.

Contributor

mgavioli commented Jul 17, 2015

@Igevorse : Great news! Thanks.

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Jul 25, 2015

It woks perfectly on my kxstudio 14.04. Really, really thanks igevorse !

daeavelwyn commented Jul 25, 2015

It woks perfectly on my kxstudio 14.04. Really, really thanks igevorse !

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Oct 26, 2015

Hi guys, i'm working with this branch for about 3 months and I have notice no issue so I just wonder when it could be merge to the master branch ?

daeavelwyn commented Oct 26, 2015

Hi guys, i'm working with this branch for about 3 months and I have notice no issue so I just wonder when it could be merge to the master branch ?

@Igevorse

This comment has been minimized.

Show comment
Hide comment
@Igevorse

Igevorse Oct 26, 2015

Contributor

@lasconic @daeavelwyn has been using this branch for 3 months and it works well.
I haven't made more commits, bugfixes or improvements since there was no need.
Thus, I think now this branch is ready for the merge.

Contributor

Igevorse commented Oct 26, 2015

@lasconic @daeavelwyn has been using this branch for 3 months and it works well.
I haven't made more commits, bugfixes or improvements since there was no need.
Thus, I think now this branch is ready for the merge.

@Igevorse Igevorse changed the title from Assigning MIDI port/channel to instruments [don't merge, welcome for testing] to Assigning MIDI port/channel to instruments [ready to merge] Oct 26, 2015

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Oct 26, 2015

@Igevorse glad to read this :)

daeavelwyn commented Oct 26, 2015

@Igevorse glad to read this :)

@lasconic lasconic merged commit a8d8b35 into musescore:master Oct 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ao2

This comment has been minimized.

Show comment
Hide comment
@ao2

ao2 Sep 9, 2016

Hi, I see this pull request as "merged" but I don't see the port and channel boxes in the mixer in MuseScoreNightly.

ao2 commented Sep 9, 2016

Hi, I see this pull request as "merged" but I don't see the port and channel boxes in the mixer in MuseScoreNightly.

@ao2

This comment has been minimized.

Show comment
Hide comment
@ao2

ao2 Sep 9, 2016

OK, sorry for the noise, I had to enable them in the preferences: Edit -> Preferences -> Score

ao2 commented Sep 9, 2016

OK, sorry for the noise, I had to enable them in the preferences: Edit -> Preferences -> Score

@laconbass

This comment has been minimized.

Show comment
Hide comment
@laconbass

laconbass Oct 21, 2016

I'm trying to enable this option, I've searched for it Preferences -> Score as suggested by @ao2 . What version should I have to be able to use it? I have 2.0.3 (3c7a69d) currently installed, may I need a higher rev? Thanks in advance!

laconbass commented Oct 21, 2016

I'm trying to enable this option, I've searched for it Preferences -> Score as suggested by @ao2 . What version should I have to be able to use it? I have 2.0.3 (3c7a69d) currently installed, may I need a higher rev? Thanks in advance!

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Oct 21, 2016

@laconbass it seems to me this option is available from version 2.1 and higher. You can actually use it in the nightly builds (but those builds are really unstable) as shown in the screenshot below.

Tips: to see midi options, you have to click on the "+" button near the M button

musescore-3 0-unstable-nightly

daeavelwyn commented Oct 21, 2016

@laconbass it seems to me this option is available from version 2.1 and higher. You can actually use it in the nightly builds (but those builds are really unstable) as shown in the screenshot below.

Tips: to see midi options, you have to click on the "+" button near the M button

musescore-3 0-unstable-nightly

@laconbass

This comment has been minimized.

Show comment
Hide comment
@laconbass

laconbass Oct 21, 2016

Ok, I will build from source and check it. Thanks!

laconbass commented Oct 21, 2016

Ok, I will build from source and check it. Thanks!

@Linwood-F

This comment has been minimized.

Show comment
Hide comment
@Linwood-F

Linwood-F Apr 4, 2017

Did this get pulled from 2.1? I just built 2.1 from source today, and it doesn't show up there. The mixer is there, but no midi stuff (and no "+" to check). I looked in the 3.0 nightly and do see it there, but not 2.1.

Does that mean in 2.1 there is no way to select midi channel for output?

Linwood-F commented Apr 4, 2017

Did this get pulled from 2.1? I just built 2.1 from source today, and it doesn't show up there. The mixer is there, but no midi stuff (and no "+" to check). I looked in the 3.0 nightly and do see it there, but not 2.1.

Does that mean in 2.1 there is no way to select midi channel for output?

@lasconic

This comment has been minimized.

Show comment
Hide comment
@lasconic

lasconic Apr 4, 2017

Member

I believe it's too big of a change to be in 2.1. It would make file incompatible with 2.0.X

Member

lasconic commented Apr 4, 2017

I believe it's too big of a change to be in 2.1. It would make file incompatible with 2.0.X

@daeavelwyn

This comment has been minimized.

Show comment
Hide comment
@daeavelwyn

daeavelwyn Apr 4, 2017

daeavelwyn commented Apr 4, 2017

@lasconic

This comment has been minimized.

Show comment
Hide comment
@lasconic

lasconic Apr 4, 2017

Member

Using nightly builds based on master, there is no chance that the mscz files you are created will open in MuseScore 3. Do keep that in mind.

Member

lasconic commented Apr 4, 2017

Using nightly builds based on master, there is no chance that the mscz files you are created will open in MuseScore 3. Do keep that in mind.

@Linwood-F

This comment has been minimized.

Show comment
Hide comment
@Linwood-F

Linwood-F Apr 4, 2017

Thanks @lasconic , the comments above indicated it was there, so was confused, probably was merged them pulled. @daeavelwyn I've run 3.0 a bit, and it is just not that usable yet. Since I wrote the midi player I am using, I will just adjust it to hard code some changes based on tracks. The problem is that the vocal line on a 3 staff piano piece is coming out as channel 1, with the grand staff 2, and the Pianodisc player I am sending to has only channel 1 so only the vocal line plays. But I can fix outside.

Linwood-F commented Apr 4, 2017

Thanks @lasconic , the comments above indicated it was there, so was confused, probably was merged them pulled. @daeavelwyn I've run 3.0 a bit, and it is just not that usable yet. Since I wrote the midi player I am using, I will just adjust it to hard code some changes based on tracks. The problem is that the vocal line on a 3 staff piano piece is coming out as channel 1, with the grand staff 2, and the Pianodisc player I am sending to has only channel 1 so only the vocal line plays. But I can fix outside.

@ao2

This comment has been minimized.

Show comment
Hide comment
@ao2

ao2 Apr 13, 2017

Hi, maybe people here can also comment about this related feature request:
https://musescore.org/en/node/138681

ao2 commented Apr 13, 2017

Hi, maybe people here can also comment about this related feature request:
https://musescore.org/en/node/138681

@virtualdxs

This comment has been minimized.

Show comment
Hide comment
@virtualdxs

virtualdxs Jun 1, 2018

@lasconic Is there a timeframe on MuseScore 3? Has anything changed? I'm just curious when this feature will be usable.

virtualdxs commented Jun 1, 2018

@lasconic Is there a timeframe on MuseScore 3? Has anything changed? I'm just curious when this feature will be usable.

@anatoly-os

This comment has been minimized.

Show comment
Hide comment
@anatoly-os

anatoly-os Jun 1, 2018

Contributor

Hi @virtualdxs, did you try the latest nightly? It is definitely more usable than year ago :)

Contributor

anatoly-os commented Jun 1, 2018

Hi @virtualdxs, did you try the latest nightly? It is definitely more usable than year ago :)

@virtualdxs

This comment has been minimized.

Show comment
Hide comment
@virtualdxs

virtualdxs Jun 1, 2018

I have not. My main worry is about the file format - I want to guarantee that my music is usable by mscore 3. Has the format been finalized? If not, can I force it to save in mscore 2 format as well as the format it uses (as two different operations)?

virtualdxs commented Jun 1, 2018

I have not. My main worry is about the file format - I want to guarantee that my music is usable by mscore 3. Has the format been finalized? If not, can I force it to save in mscore 2 format as well as the format it uses (as two different operations)?

@anatoly-os

This comment has been minimized.

Show comment
Hide comment
@anatoly-os

anatoly-os Jun 1, 2018

Contributor

Im afraid the answer is No to both your questions. File format is not finalized due to upcoming project of GSoC student. 3.0 cannot save file in 2.x format.

Contributor

anatoly-os commented Jun 1, 2018

Im afraid the answer is No to both your questions. File format is not finalized due to upcoming project of GSoC student. 3.0 cannot save file in 2.x format.

@MarcSabatella

This comment has been minimized.

Show comment
Hide comment
@MarcSabatella

MarcSabatella Jun 1, 2018

Contributor
Contributor

MarcSabatella commented Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment