From 1a82b43200b81f27352ca1e26de89e676deaaf86 Mon Sep 17 00:00:00 2001 From: Casper Jeukendrup <48658420+cbjeukendrup@users.noreply.github.com> Date: Wed, 1 May 2024 00:03:28 +0200 Subject: [PATCH] Revert "Set PopupView as parent of PopupWindow_QQuickView" This reverts commit 2fa36e3371700c49c37ac1a19b1eb47872c772c7. That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3b43784db8164ee7204d8a6f470d9d68d6, and the commit caused other problems that are not quite trivial (#22640 and #22641). Therefore, we'll revert this commit for now. --- src/framework/uicomponents/view/popupview.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/framework/uicomponents/view/popupview.cpp b/src/framework/uicomponents/view/popupview.cpp index d3c6fcebe075e..4637ae936eba0 100644 --- a/src/framework/uicomponents/view/popupview.cpp +++ b/src/framework/uicomponents/view/popupview.cpp @@ -132,7 +132,7 @@ void PopupView::init() return; } - m_window = new PopupWindow_QQuickView(this); + m_window = new PopupWindow_QQuickView(); m_window->init(engine, isDialog(), frameless()); m_window->setOnHidden([this]() { onHidden(); }); m_window->setContent(m_component, m_contentItem);