Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zerberus sample pool #2782

Open
wants to merge 18 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@hpfmn
Copy link
Contributor

commented Aug 11, 2016

this my work on progress on disk streaming for zerberus - it kind of works but is still full of bugs and the disk threads sucks 100% CPU ;)

@hpfmn

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2016

now it doesn't use 100% CPU anymore ;)

while (true) {
samplePool->fillSteamBuffers();
// TODO use a time based on voices and buffer size!
usleep(100);

This comment has been minimized.

Copy link
@lasconic

lasconic Aug 11, 2016

Member

Ideally, I guess that this should wait and be woken up when there is actual work to do, meaning filling buffers.

std::map<QString, Sample*> filename2sample;
std::vector<SampleStream *> streams;
bool _streaming = true;
float _fillPercentage = 0.5;

This comment has been minimized.

Copy link
@lasconic

lasconic Aug 16, 2016

Member

Can you add a comment to explain what _streamBufferSize and _fillPercentage are used for? I'm sure it will be appreciated in a year for now :) (Idem for the worker and mutex)

@RobFog

This comment has been minimized.

Copy link

commented Sep 30, 2016

Is this PR still WIP or does it just need a rebase to be merged?

@hpfmn

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2016

It is kind of WIP because it needs more performance optimizations/testing!

@hpfmn hpfmn force-pushed the hpfmn:ZerberusSamplePool branch from 82ee393 to ffc3681 Oct 4, 2016

@anatoly-os

This comment has been minimized.

Copy link
Contributor

commented May 14, 2018

It is still open and still in progress. Such an awesome feature! @hpfmn are you around to finish it or to give some recomendations related to code to finish it by someone else?

@anatoly-os anatoly-os added the Priority label Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.