Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #91571, fix #114366 again, and other menu updates #2857

Closed
wants to merge 1 commit into from

Conversation

IsaacWeiss
Copy link
Contributor

@IsaacWeiss IsaacWeiss commented Oct 7, 2016

Second round of menu changes, again mostly discussed on the forums previously.

  • Page View, Continuous View, and Single Page View added to View menu
  • Toolbars submenu added to View menu with toolbar toggles and Customize Toolbars
  • Zoom In and Out moved to Zoom submenu, with Zoom to 100% added
  • Documents Side by Side and Documents Stacked renamed to Split View Left/Right and Split View Top/Bottom
  • Insert Pitch commands added to Add > Notes menu
  • Delete and Remove (Timewise Delete) added to Edit menu
  • Regroup Rhythms (Reset Note and Rest Groupings) added to Tools menu
  • Remove (Timewise Delete) added to context menu for barlines, measures, notes and rests
  • Load Style removed from context menu for canvas

Still to do, needing advice (though none block this from merging and being useful):

  • Check the appropriate layout mode entry in the View menu on score load
  • Add Insert Rest command (per https://musescore.org/en/node/126986), some commented out lines already added in preparation
  • Disable Delete and Remove in Edit menu when they’re not applicable

@lasconic
Copy link
Contributor

lasconic commented Oct 7, 2016

Documents Side by Side and Documents Stacked renamed to Split View Left/Right and Split View Top/Bottom

Why? Where is the discussion? I remember we choose this name after some discussion and checking other software: https://musescore.org/en/node/3542
It would be great if you don't change stuff in a single PR without previous discussion to avoid discussion like https://musescore.org/en/node/120676

So I would prefer a single PR to address each item, after a discussion. Even if it's a short one.

@IsaacWeiss
Copy link
Contributor Author

@lasconic:
As I just mentioned in a comment on the (closed for good reason) #2804, I unfortunately sometimes fail to make a note of where I found ideas. I did read https://musescore.org/en/node/3542 (perhaps around the time that the names of the vertical/horizontal/column/row page view/layout/scrolling setting was under discussion), but I didn't comment on it at the time; and I may be the only one who has a problem with the "Documents" wording, and opening a PR without prior discussion was bad form.

Should I close this and start again from the beginning, one thing at a time?

@lasconic
Copy link
Contributor

lasconic commented Oct 7, 2016

If you think something is not controversial, you can do a PR. Changing wording is always controversial though... The insertions and deletions in menus looks good. Adding WIP commented code is not good, make a new PR if you need help putting something together. Hope it makes sense.

@IsaacWeiss
Copy link
Contributor Author

Split View question asked at https://musescore.org/en/node/3542.

@IsaacWeiss IsaacWeiss closed this Oct 19, 2016
@IsaacWeiss IsaacWeiss deleted the menus branch August 13, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants