Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #269378 Double Coda… #3472

Closed

Conversation

Projects
None yet
2 participants
@jeetee
Copy link
Contributor

commented Feb 16, 2018

…leads to not detecting 'final' playthrough after 2nd jump rewind logic.

Added test file from Miré as repeat47

@@ -441,8 +441,10 @@ void RepeatList::unwindSection(Measure* sectionStartMeasure, Measure* sectionEnd
for (Measure* m = _score->firstMeasure(); m; m = m->nextMeasure())
m->setPlaybackCount(0);
}
else { // set each measure to have it play it's final time, but only from our jumptarget on until the current measure
for (Measure* m = jumpToMeasure; (m && (m != currentMeasure->nextMeasure())); m = m->nextMeasure()) {
else { // set each measure to have it play it's final time

This comment has been minimized.

Copy link
@lasconic

lasconic Feb 16, 2018

Member

there is a typo here "its final time" no '

@lasconic

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

fixed the typo and merged manually in e274a41
Will merge manually in 2.2 and adapt the test

@lasconic

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

Merged, tested, and commited in 2.2 1d3a9d3

@lasconic lasconic closed this Feb 16, 2018

@jeetee jeetee deleted the jeetee:269378_double_coda_jump_rewind_logic branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.