Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare duration() of tuplet with calculated duration to see if it… #3571

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@mattmcclinch
Copy link
Contributor

commented Mar 22, 2018

… needs to be sanitized

#3526 may have fixed some issues with the sanitizeTuplet() function, but it allows tuplets to go unsanitized when testDuration is equal to baseLenDuration, but duration() is incorrect.

@mattmcclinch

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2018

It is documented that Tuplet::sanitizeTuplet() does not work for not-completely filled tuplets, and indeed it will "sanitize" a tuplet that is simply incomplete (if it can). This is not a problem if the only missing elements are at the beginning of the tuplet or at the end (or both). The result is a valid tuplet with no extra elements that the user did not want. But if the missing elements are in the middle, it causes problems. Thankfully, it is easy to check for missing elements in the middle of the tuplet before sanitizing it. I am updating this PR.

@mattmcclinch mattmcclinch force-pushed the mattmcclinch:sanitize-tuplet branch from dfcddfa to 6e87c9d Mar 23, 2018

@lasconic lasconic merged commit ebf4e54 into musescore:master Mar 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mattmcclinch mattmcclinch deleted the mattmcclinch:sanitize-tuplet branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.