fix #271529: incorrect stem position for some noteheads in layout #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoly-os
force-pushed
the
271529_stemPosFix
branch
5 times, most recently
from
e162f52
to
a5d7706
Compare
Implemented correct notehead bbox width and origin calculations. Fixed note and chord stems, ledger lines, beams, dots, articulation, slur and chord positions.
anatoly-os
force-pushed
the
271529_stemPosFix
branch
from
a5d7706
to
4facafc
Compare
Refs need alignment
Jojo-Schmitz
reviewed
May 5, 2018
| if (note->mirror()) | ||
| x += note->headWidth() * (up() ? -1.0 : 1.0); | ||
| x += (note->headBodyWidth()) * (up() ? -1.0 : 1.0); |
anatoly-os
added a commit
to anatoly-os/MuseScore
that referenced
this pull request
May 10, 2018
Manually merged changes from musescore#3653 to 2.3
anatoly-os
added a commit
to anatoly-os/MuseScore
that referenced
this pull request
May 11, 2018
Manually merged changes from musescore#3653 to 2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented correct notehead bbox width and origin calculations. Fixed
stems, ledger lines, beams, dots, articulation positions.
The implementation equals #3649