Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #277030: Crash on changing a property of bracket in a part in Inspector #4033

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
2 participants
@mattmcclinch
Copy link
Contributor

commented Oct 15, 2018

See https://musescore.org/en/node/277030.

This reverts changes that I had made to Score::doLayoutRange(). The intention was to remember which brackets were selected, so that they could be selected again after being recreated. Unfortunately, the code is not working as intended, and it is what leads to the crash.

@anatoly-os

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

@mattmcclinch which changes exactly do you mean? Could you please mention the related PR?

@anatoly-os anatoly-os added the review label Oct 15, 2018

@mattmcclinch

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2018

The related PR is #3735. The changes to Score::doLayoutRange() had nothing to do with fixing the bug mentioned in that PR’s associated issue.

@anatoly-os anatoly-os merged commit 4e0c309 into musescore:master Oct 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.