fix #277090: reset tempo only for the relevant range on layout #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libmscore/score.cpp
Outdated
| @@ -71,6 +71,8 @@ | |||
| #include "breath.h" | |||
| #include "instrchange.h" | |||
|
|
|||
| #include <limits> | |||
There was a problem hiding this comment.
Isn't this more a candidate for all.h? #include <limits.h> is in there already
There was a problem hiding this comment.
I didn't know that all.h contains also includes from C++ standard library. Yes, then this include is not necessary here.
dmitrio95
force-pushed
the
277090-tempo-reset
branch
from
1870876
to
175dd22
Compare
|
Some tests are failing |
anatoly-os
added a commit
that referenced
this pull request
Oct 31, 2018
fix #277090: reset tempo only for the relevant range on layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with playback tempo change on editing certain parts of a score. This happened because tempo map is cleared on layout and is then rebuilt from scratch, though only for the layout range. This patch makes tempomap be reset only in the layout range too thus preventing loss of tempo information leading to unwanted playback tempo behavior.