Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #278874: fix regressions caused by transition to the new text style format #4236

Merged
merged 2 commits into from Nov 27, 2018

Conversation

@dmitrio95
Copy link
Contributor

commented Nov 27, 2018

This PR fixes the noticed regressions caused by the recent ffdab67 commit.
The fixed regressions have been reported here:
https://musescore.org/en/node/278874

@dmitrio95 dmitrio95 force-pushed the dmitrio95:278874-style-window-crash branch from 1a764fd to 8a93b0c Nov 27, 2018

@dmitrio95

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2018

Tests were failing due to removing in the same commit old lines for text styles without replacing them with new. I added them back.

@anatoly-os anatoly-os merged commit e46c668 into musescore:master Nov 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.