Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #281867 crash on Mac when stopping porttime #4822

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@AntonioBL
Copy link
Contributor

commented Mar 22, 2019

No description provided.

@AntonioBL

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

This is maybe the safest solution to the problem, even if it involves modifying portmidi source. Actually, a similar solution is already done under Linux (

if (pt_thread_created) {
) and under Windows (
if (time_callback && timer_id) {
).
It seems there is no problem with the other Mac implementation (ptmacosx_mach.c).

@anatoly-os anatoly-os merged commit d79d294 into musescore:master Mar 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AntonioBL AntonioBL deleted the AntonioBL:porttime_mac branch Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.