Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix #279980, fix #287723, fix #186111: rehearsal mark alignment #4919
There's been a bunch of give and take over the years on the best way to position rehearsal marks with respect to horizontal alignment. While we have a solution that works decently well in a lot of cases, it does not do well well if there are repeats, or in the case of mid-measure key changes. Also, there was a regression between 2.3.2 and 3.0 where we lost correct alignment of right-aligned rehearsal marks (here: c1726bb#diff-2ee382c946a5e3ac5f7506d72dae8919).
This PR address these issues. It's not a big change; it just restructures the calculations in a way that covers the different cases: (header / no header, repeat / no repeat, start / middle of system, left / right / center alignment. The calculations themselves are basically same as always, I just apply them more consistently. Only real new aspect is the specific check for repeats.
Here is the result: