fix #282165: Mute voice produces note that doesn't stop when overlap present #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattmcclinch thanks! Will a MIDI test catch the bug and verify the fix? If so, could you please add one? |
mattmcclinch
force-pushed
the
291038-fixup-midi
branch
from
8199e41
to
01a222d
Compare
|
I added a test which uncovered a bug in MIDI export. I have fixed this bug as well, using the same logic as before. |
anatoly-os
reviewed
Aug 1, 2019
synthesizer/event.cpp
Outdated
| @@ -391,8 +394,18 @@ void EventMap::fixupMIDI() | |||
|
|
|||
| auto it = begin(); | |||
| while (it != end()) { | |||
| NPlayEvent event = it->second; | |||
There was a problem hiding this comment.
Isn't it possible to avoid code duplication? Extract a method?
There was a problem hiding this comment.
Yes, I agree that it is better to avoid code duplication. I just pushed a change to this branch that does what you suggest.
mattmcclinch
force-pushed
the
291038-fixup-midi
branch
from
01a222d
to
8b33764
Compare
mattmcclinch
force-pushed
the
291038-fixup-midi
branch
from
8b33764
to
711b7ab
Compare
mattmcclinch
changed the title
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/282165.
This uses the same logic as in
Seq::playEvent()for determining whether or not the event corresponds to a muted track.