Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #293017: Plugin: Enable elements selection from plugins #5259

Open
wants to merge 1 commit into
base: master
from

Conversation

@DLLarson
Copy link
Contributor

commented Aug 6, 2019

Extends the Score.selection.elements list implementation to allow modifications
so that plugin scripts can programatically select any element that can be selected
from the GUI.

@DLLarson DLLarson force-pushed the DLLarson:plugin-enable-element-selections branch from e5d4509 to bc9dfda Aug 6, 2019

{
Ms::Selection* sel = static_cast<Ms::Selection*>(l->data);
return wrap(sel->elements()[i]);
//return wrap(&(*(static_cast<Selection*>(l->data)))->elements()[i], reinterpret_cast<Element*>(l->object));

This comment has been minimized.

Copy link
@GaspardPO

GaspardPO Aug 13, 2019

It looks like forgotten commented code.

This comment has been minimized.

Copy link
@DLLarson

DLLarson Aug 13, 2019

Author Contributor

good catch. now gone.
-Dale

@DLLarson DLLarson force-pushed the DLLarson:plugin-enable-element-selections branch from bc9dfda to ae6a893 Aug 13, 2019

@DLLarson DLLarson force-pushed the DLLarson:plugin-enable-element-selections branch from ae6a893 to bbe3e33 Aug 21, 2019

@dmitrio95 dmitrio95 added the Plugins label Aug 27, 2019

@DLLarson DLLarson force-pushed the DLLarson:plugin-enable-element-selections branch from bbe3e33 to daabc41 Aug 27, 2019

Fix #293017: Plugin: Enable elements selection from plugins
Extends the Score.selection.elements list to allow modifications
so plugin scripts can programatically select any element that can
be selected from the GUI.

@DLLarson DLLarson force-pushed the DLLarson:plugin-enable-element-selections branch from daabc41 to cd7854d Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.