Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #294126: cannot navigate to measure elements #5327

Merged

Conversation

@MarcSabatella
Copy link
Contributor

commented Sep 17, 2019

Resolves: https://musescore.org/en/node/294126

The navigation code for next-element and previous-elements ignores measure elements
(elements in the el() list for the measure).
This change adds handling for this
by checking for measure elements before moving to the next or previous measure
in Segment::nextElement() and Segment::previousElement(),
There is corresponding code in Measure::nextElementStaff()
and in Measure::previousElementStaff()
to iterate through multiple elements if present.

Testscript "accessible1" updated to check this.

This PR replaces the corresponding code in PR #5270

The navigation code for next-element and previous-elements ignores measure elements
(elements in the el() list for the measure).
This change adds handling for this
by checking for measure elements before moving to the next or previous measure
in Segment::nextElement() and Segment::previousElement(),
There is corresponding code in Measure::nextElementStaff()
and in Measure::previousElementStaff()
to iterate through multiple elements if present.
@MarcSabatella MarcSabatella added the RNIB label Sep 17, 2019
@anatoly-os anatoly-os merged commit 4d4f6f5 into musescore:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
anatoly-os added a commit that referenced this pull request Oct 2, 2019
…lements

fix #294126: cannot navigate to measure elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.