Fix #305676: fix barline translations #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Jun 5, 2020
•
Jojo-Schmitz
commented
- Fix mismatch in barline translations for master palette
- Fix barline translations in workspaces palettes
Jojo-Schmitz
changed the title
Jojo-Schmitz
commented
Jun 5, 2020
| @@ -122,6 +122,7 @@ const char* PaletteCell::translationContext() const | |||
| switch (type) { | |||
| case ElementType::ACCIDENTAL: | |||
| case ElementType::ARTICULATION: | |||
| case ElementType::BAR_LINE: | |||
There was a problem hiding this comment.
using "symUserNames" context for barlines too
Jojo-Schmitz
force-pushed
the
barlines-translation
branch
from
4c8b289
to
ce561ed
Compare
2 tasks
Jojo-Schmitz
changed the title
29 tasks
|
Seems like this PR is not needed for master due to the merged #6119. @Jojo-Schmitz what do you think? |
|
Let me check that again... last time I looked I think it was still needed |
|
Yes, you're right, sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.