Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306509: Improvements to zoom functionality #6186

Merged

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented Jun 9, 2020

Resolves: #306509

Made several significant usability improvements to the zoom functionality, and also fixed several bugs.

Although there are several different changes contained here, the code for them is all intertwined and it would have been difficult and time-consuming to attempt to separate them all into separate PRs.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Spire42 Spire42 mentioned this pull request Jun 9, 2020
12 tasks
@Spire42 Spire42 force-pushed the 306509-improvements-to-zoom-functionality branch 5 times, most recently from 3bdeae6 to a2aa740 Compare June 9, 2020 15:16
@anatoly-os
Copy link
Contributor

Please remove that "merge" commit by squashing the commits.

@Spire42 Spire42 force-pushed the 306509-improvements-to-zoom-functionality branch from fde8457 to a2e6f87 Compare June 9, 2020 16:00
@MarcSabatella
Copy link
Contributor

Can you summarize the changes? I saw some discussion of changes in where the focus is while zooming, and it is important to understand that while for some of these cases the current behavior might be not optimal even indeed likely to be purely accidentals of the implementation, some of these have been carefully crafted over the years in response to extensive input from users, and it is important not to disturb those cases.

Most important I can remember offhand - Ctrl+wheel must continue to center on the mouse pointer, zoom out and zoom in should return to same position where possible.

@Spire42
Copy link
Contributor Author

Spire42 commented Jun 9, 2020

Can you summarize the changes?

I wrote about them in great detail in issue #306509.

Nothing is disturbed other than how much each zoom step zooms in or out, which is now configurable instead of hard-coded. Mouse zoom relative to the pointer is unchanged.

Made several significant usability improvements to the zoom functionality, and also fixed several bugs.

Although there are several different changes contained here, the code for them is all intertwined and it would have been difficult and time-consuming to attempt to separate them all into separate PRs.
@Spire42 Spire42 force-pushed the 306509-improvements-to-zoom-functionality branch from a2e6f87 to 846c370 Compare June 9, 2020 16:24
@MarcSabatella
Copy link
Contributor

Great, thanks. Looking forward to the saner steps for keyboard zoom and relationship to mouse!

@anatoly-os anatoly-os merged commit c9f8773 into musescore:3.x Jun 10, 2020
anatoly-os added a commit that referenced this pull request Jun 10, 2020
…ctionality

Fix #306509: Improvements to zoom functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants