New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic JACK MIDI Out support #930

Merged
merged 3 commits into from Jun 3, 2014

Conversation

Projects
None yet
4 participants
@Igevorse
Contributor

Igevorse commented May 24, 2014

Just basic JACK MIDI Out support
Fixed some bugs and crashes (http://igevorse.lited.net/bugs/)
JACK Transport Timebase implemented

Show outdated Hide outdated mscore/seq.cpp
// Muting all notes
if(preferences.useAlsaAudio || preferences.useJackAudio || preferences.usePulseAudio || preferences.usePortaudioAudio || preferences.useOsc)
stopNotes();
if(preferences.useJackMidi)

This comment has been minimized.

@lasconic

lasconic May 29, 2014

Member

Why sending sustain off only for Jack midi? and why not stopping the notes for jack midi?

@lasconic

lasconic May 29, 2014

Member

Why sending sustain off only for Jack midi? and why not stopping the notes for jack midi?

This comment has been minimized.

@Igevorse

Igevorse May 29, 2014

Contributor

stopNotes() stops the internal synthesizer, there is no need to call it for JACK MIDI.
Sending sustain off only for JACK MIDI is my mistake. I've already deleted this line (671) in my current dev. version.

@Igevorse

Igevorse May 29, 2014

Contributor

stopNotes() stops the internal synthesizer, there is no need to call it for JACK MIDI.
Sending sustain off only for JACK MIDI is my mistake. I've already deleted this line (671) in my current dev. version.

Show outdated Hide outdated mscore/seq.cpp
@@ -652,6 +652,11 @@ void Seq::process(unsigned n, float* buffer)
if (driverState != state) {
if (state == TRANSPORT_STOP && driverState == TRANSPORT_PLAY) {
state = TRANSPORT_PLAY;
// Changing GUI

This comment has been minimized.

@lasconic

lasconic May 29, 2014

Member

This is for handling Jack transport incoming play command right? Could you make it clearer in the comment?

@lasconic

lasconic May 29, 2014

Member

This is for handling Jack transport incoming play command right? Could you make it clearer in the comment?

@Jojo-Schmitz

This comment has been minimized.

Show comment
Hide comment
@Jojo-Schmitz

Jojo-Schmitz May 31, 2014

Contributor

Same Travis failure as in PR #943, and it too is 3 commits behind upstream/master, so I guess here too a rebase might fix it.

Contributor

Jojo-Schmitz commented May 31, 2014

Same Travis failure as in PR #943, and it too is 3 commits behind upstream/master, so I guess here too a rebase might fix it.

@Jojo-Schmitz Jojo-Schmitz referenced this pull request May 31, 2014

Merged

Repeated dynamics fix #943

wschweer added a commit that referenced this pull request Jun 3, 2014

@wschweer wschweer merged commit c1725a2 into musescore:master Jun 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@lasconic

This comment has been minimized.

Show comment
Hide comment
Member

lasconic commented Jun 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment