Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert as many "enum" as possible to "enum class", and make them ": char" in the due course #4 #936

Merged
merged 14 commits into from
May 30, 2014
Merged

convert as many "enum" as possible to "enum class", and make them ": char" in the due course #4 #936

merged 14 commits into from
May 30, 2014

Commits on May 30, 2014

  1. convert enum UpDownMode into enum class

    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    d8ee64b View commit details
    Browse the repository at this point in the history

  2. convert enum StaffGroup into enum class

    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    cde0a39 View commit details
    Browse the repository at this point in the history

  3. convert unnamed enum into enum TextStyleType 

    more work needed to make it an enum class
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    79474e3 View commit details
    Browse the repository at this point in the history

  4. convert enum BarLineType into enum class

    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    eac6e60 View commit details
    Browse the repository at this point in the history

  5. convert unnamed enum into enum class IconType 

    and change to a better sentinel for end of list.
Also move the Q_DECLARE_METATYPE(Ms::ValueType) nearer to its
definition.

This should conclude the work on the enums in libmsore/mscore.h.
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    f76946c View commit details
    Browse the repository at this point in the history

  6. convert enum LayoutMode into enum class

    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    6c3c437 View commit details
    Browse the repository at this point in the history

  7. convert enum PlayMode into enum class 

    and make enum LayoutFlag a ": char" (making it an enum class requires
more work, as it is used for flags)
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    562c92e View commit details
    Browse the repository at this point in the history

  8. convert unnamed enum into enum class Pad

    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    4bf9d60 View commit details
    Browse the repository at this point in the history

  9. convert enum FileError into enum class 

    but an attempt to get rid of the FILE_ prefix failed miserably whith
some bizarre compiler error message.
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    d490271 View commit details
    Browse the repository at this point in the history

  10. convert enum Key into enum class 

    and to be able to ret rid of the KEY_ prefix, change enum Tpc's members
by adding (back) the prefix TPC_
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    4e048f1 View commit details
    Browse the repository at this point in the history

  11. convert enum MidiType into enum class 

    more work needed in midi/midiinstrument.{h,cpp}?
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    7bffd66 View commit details
    Browse the repository at this point in the history

  12. change enum ShortcutFlags to ": char" 

    as it is used for flags, turning into an enum would require much more
work
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    7805c3d View commit details
    Browse the repository at this point in the history

  13. convert enum ChunkType into enum class 

    and adjust entire file to MuseScore coding style
    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    c92201d View commit details
    Browse the repository at this point in the history

  14. whitespace cleanup

    @Jojo-Schmitz
    Jojo-Schmitz committed May 30, 2014
    Configuration menu
    Copy the full SHA
    6f3a7d1 View commit details
    Browse the repository at this point in the history