Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: fix #1285 bug #1425

Open
wants to merge 1 commit into
base: master
from
Open

Popover: fix #1285 bug #1425

wants to merge 1 commit into from

Conversation

@Chubarkin
Copy link

Chubarkin commented Nov 11, 2019

Hello!
My PR fixes memory leak errors that exist in components that use the Popover component with the Scroll directive.

Many event listeners were registered, but the target element did not change.
This problem we can see on https://muse-ui.org/#/en-US/select using Memory Chrome DevTools.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #1425 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
+ Coverage   30.18%   30.24%   +0.05%     
==========================================
  Files         220      220              
  Lines        3578     3581       +3     
  Branches      749      750       +1     
==========================================
+ Hits         1080     1083       +3     
  Misses       1880     1880              
  Partials      618      618
Impacted Files Coverage Δ
src/internal/directives/scroll.js 84.21% <100%> (+2.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f78df...fed05bb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.