Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #392

Merged
merged 7 commits into from Aug 29, 2018

Conversation

@xandfury
Copy link
Collaborator

commented Aug 10, 2018

This would update conpot's docker file to be 0.6 ready.

@xandfury xandfury requested review from creolis and adepasquale Aug 10, 2018

@coveralls

This comment has been minimized.

Copy link

commented Aug 10, 2018

Pull Request Test Coverage Report for Build 1090

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.2%) to 71.381%

Files with Coverage Reduction New Missed Lines %
conpot/core/databus.py 1 85.53%
conpot/core/attack_session.py 2 94.12%
conpot/protocols/ipmi/ipmi_server.py 2 68.8%
conpot/protocols/http/command_responder.py 4 55.06%
conpot/protocols/ftp/ftp_handler.py 5 82.23%
Totals Coverage Status
Change from base Build 1086: 0.2%
Covered Lines: 5380
Relevant Lines: 7537

💛 - Coveralls
@xandfury

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 10, 2018

This is WIP. Please do not merge yet.

@xandfury

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 28, 2018

Done! Should also fix #398. Someone (@adepasquale ) might also need to trigger the build as always 😉

@creolis
Copy link
Member

left a comment

LGTM! @adepasquale - Your review would be very appreciated, even post-merge :)

add docker badges
add docker badges from docker hub
@t3chn0m4g3

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

@xandfury Confirmed, this will fix #398

@creolis creolis merged commit eeabbbf into mushorg:master Aug 29, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 71.381%
Details
@creolis

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

<3

@creolis creolis referenced this pull request Aug 29, 2018
@t3chn0m4g3

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2018

Thanks guys :bowtie:

@adepasquale

This comment has been minimized.

Copy link
Member

commented Sep 1, 2018

LGTM too!

The build is triggered automatically after pushes to master ("latest" tag on Docker hub).

I've just configured an additional tagging mechanism; it will work for GitHub tags starting with "Release_" and create a corresponding versioned build on Docker Hub.

@creolis

This comment has been minimized.

Copy link
Member

commented Sep 1, 2018

<3 sanx Andrea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.