Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telnet python 3 #1

Merged
merged 5 commits into from Jul 16, 2018

Conversation

@xandfury
Copy link

commented Jul 11, 2018

Build Status Coverage Status Codacy Badge

Initial work on telnet lib.

@@ -0,0 +1,34 @@
language: python
python:
- '3.5'

This comment has been minimized.

Copy link
@glaslos

glaslos Jul 12, 2018

Member

what about 3.6?


import gevent, gevent.queue
import gevent

This comment has been minimized.

Copy link
@glaslos

glaslos Jul 12, 2018

Member

we probably want to replace gevent with asyncio

This comment has been minimized.

Copy link
@xandfury

xandfury Jul 12, 2018

Author

Hey Lukas. Actually Daniel and I thought of using fork for Conpot's telnet server. So the choice of py35 and gevent are derived from there. I have added py36 support though.
It only makes sense to have multiple handlers if we plan to use this fork in multiple projects.

cc: @creolis What do you think?

This comment has been minimized.

Copy link
@glaslos

glaslos Jul 13, 2018

Member

@xandfury Sorry, my bad, stick to gevent for now

tox.ini Outdated
@@ -0,0 +1,20 @@
[tox]
envlist = py35

This comment has been minimized.

Copy link
@glaslos
tox.ini Outdated

[testenv]
basepython =
py35: python3.5

This comment has been minimized.

Copy link
@glaslos
@xandfury

This comment has been minimized.

Copy link
Author

commented Jul 12, 2018

@glaslos @creolis On a side note, please refrain from squashing commits. I think one of these days someone might do a git bisect to look for potential errors.

@glaslos

This comment has been minimized.

Copy link
Member

commented Jul 13, 2018

LGTM

@creolis creolis merged commit 79244e6 into mushorg:master Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.