Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ornaments visual attribute classes should be members of att.altsym #232

Closed
raffazizzi opened this issue Jun 8, 2015 · 1 comment
Closed

Ornaments visual attribute classes should be members of att.altsym #232

raffazizzi opened this issue Jun 8, 2015 · 1 comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Priority: Medium Status: Needs Patch Type: Bug indicates that a bug has been spotted

Comments

@raffazizzi
Copy link
Member

Currently it's not possible to specify an alternative symbol for an ornament, even though the guidelines say (from the desc of @form on mordent): "Another attribute in the visual domain would be necessary in order to be completely explicit about which visual symbol is actually to be rendered."

The following attribute classes should be members of att.altsym:

  • att.mordent.vis
  • att.turn.vis
  • att.trill.vis
raffazizzi added a commit to raffazizzi/music-encoding that referenced this issue Jun 8, 2015
@raffazizzi
Made ornament visual classes members of att.atlsym. Fixes upstream is…
8842413 
…sue music-encoding#232
@raffazizzi raffazizzi mentioned this issue Jun 8, 2015
Closed
@ahankinson ahankinson added Component: Core Schema changes to source/modules/* (assigned automatically) Priority: Medium Type: Feature Request indicates that new features, that do not break backward compatibility, have been proposed Status: Needs Patch labels Jun 8, 2015
@raffazizzi
Copy link
Member Author

I would also suggest that this is a bug, not an enhancement: the element's description clearly states that there should be an attribute in the visual domain that is currently missing.

@ahankinson ahankinson added Type: Bug indicates that a bug has been spotted and removed Type: Feature Request indicates that new features, that do not break backward compatibility, have been proposed labels Jun 9, 2015
raffazizzi added a commit to raffazizzi/music-encoding that referenced this issue Jun 9, 2015
@raffazizzi
Regenerated schema with ornament elements visual classes as members o…
feaecfa 
…f att.altsym (see music-encoding#232)
raffazizzi added a commit to raffazizzi/music-encoding that referenced this issue Oct 6, 2015
@raffazizzi
Made ornament visual classes members of att.atlsym. Fixes upstream is…
eb70fe3 
…sue music-encoding#232
raffazizzi added a commit to raffazizzi/music-encoding that referenced this issue Oct 6, 2015
@raffazizzi
Regenerated schema with ornament elements visual classes as members o…
fb396cd 
…f att.altsym (see music-encoding#232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Priority: Medium Status: Needs Patch Type: Bug indicates that a bug has been spotted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raffazizzi @ahankinson