New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master branch to main? #776
Comments
thanks @musicEnfanthen for bringing this up! The ODD Meeting 2021-02-25 is wondering though, whether other naming schemes would be preferable, e.g.:
This would actually better reflect our use of the current "master" branch. @music-encoding/core-contributors any comments? |
Since this would potentially affect all repos within the MEI, one idea could be to choose a branch name that works for all repos. Absolutely not insisting on |
What about
|
https://www.theserverside.com/feature/Why-GitHub-renamed-its-master-branch-to-main Having a repository without
In other words, it is useful to have a generic branch name for the most recent release for users who want always the most recent stable release, even if it is an updated release. |
We already effectively have a release branch, which is the tags; these allow you to check out the tagged branch at any given point in time. The most important question for releases is “which one?” — it doesn’t make sense for you to have a release branch but not know which release! :) main makes sense as a common, well-understood name, but it’s not really the “main” branch, since it’s the one with the least activity. Perhaps “stable” (in opposition to “develop”) is a good alternative that also indicates the purpose? It’s the one with the latest stable version. Previous stable versions can be found with the tags. |
Things get a bit more complicated with our current repo-setup. All development of MEI Specs and MEI Guidelines happen in On music-encoding/music-encoding we need:
But actually taking @ahankinson seriously we could abandon this double branch model (e.g. develop-released) as every tag (that is created upon release) can be retrieved. So we could rename |
Thanks!
It isn't the
Hm. I get where you're going, but I think keeping the most recent stable version as a branch has some advantages. The biggest advantage is that it gives us a place to merge to, and it also gives us the ability to switch between stable and develop versions without going through an intermediary tag. Otherwise, getting the code at the release tag means first creating it as a new branch, and then switching to that branch. Since it's obvious that we're always going to have a state of the code we're working on, and the most recent state that other people should use, then I think it makes sense to have both active in parallel.
If and when the need arises, it is possible to create a bugfix branch from a tag, and any time we do need a change a release we will almost certainly want to mint a new stable version incrementing the release number with the fix, which means merging the bugfix back into As a general comment, I don't really see any need to make all the repos in the organization uniform -- |
Agreed upon keeping
as you said it's convenient to have it. On music-encoding rename master to:
On the other repos rename master to:
|
+1 to 'stable' on +0 to any of the options for the other repos. Any would be fine. |
I like @ahankinson 's proposal of +1 to |
I think |
At the ODD meeting today, we discussed this a bit, and there was no full consensus to use |
It would be good to have the other viewpoints on this ticket for the benefit of those of us who could not make the meeting today, just to get those on record. (and to participate in @bwbohl 's poll!) As for how to do it, it's pretty straightforward mechanically -- I have done it for a few of my own repos. The hardest part will be to make sure all the CI scripts, etc. have been modified as well. I am happy to take the lead on doing the change, once the name has been settled. |
Thank you @ahankinson! There was someone (not giving any names ;) not totally confident with Yes, you are right, the mechanism is pretty straightforward. But we would need to make sure that all forks are informed and should provide an easy-to-find and easy-to-follow instruction. |
I am not convinced by this argument. When we make a release, we genuinely believe for it to be stable. If eventually, something is discovered and needs a new release, that's fine. Then we make the release and that one becomes the stable one. This is why we have semantic versioning. |
Dear MEI Community, following a suggestion by the Software Freedom Conservancy GitHub renamed their master-branch to main in order to avoid potentially offensive vocabulary or allusions to slavery. MEI would like to follow this lead and rename the master-branch of https://github.com/music-encoding/music-encoding and other repositories where applicable. Following the discussion on GitHub (#776) the Technical Team set up this poll to take in the community's votes on a closed list of potential new names for our current master-branch, used to disseminate tagged versions (e.g. MEI 3.0.0, MEI 4.0.0 MEI 4.0.1). Please cast your vote until 2021-04-28 using the form available at: This might be of special interest for: and fork owners: |
feedback of the poll above led to a balance between |
@ahankinson, you volunteered to start thinking about the implementation for this, is this offer still standing? |
thanks to everyone in the discussion, of course :-) |
Yes, I can do this. I can do it right now, if that's OK with everyone? |
I think we just need to make sure that our workflows don't break over the change, but other than that there's nothing that stops us… thanks! |
This changes the references in the repo documentation from 'master' to 'stable'. Fixes #776
@ahankinson Thanks for the renaming! Worked perfectly. @bwbohl @kepper Shall we continue with the other repos? (
Request for changes:
|
@musicEnfanthen Regarding sibmei, we are already discussing the renaming, see music-encoding/sibmei#169 |
@annplaksin Perfect, thanks! |
At ODD meeting today, we agreed to follow the list above. However, we need to verify that this won't break our workflows. Maybe @bwbohl, @ahankinson, @musicEnfanthen can have a look together? |
Updated the list above with necessary steps and cross-repo references |
Would like to push this forward to have the transition finished this year. @ahankinson would you be able to rename the master branches of the following repos in the next days/weeks (according to the process with the main repo)?
|
Yes, I can. However, for any site that has a published GH page attached to it, it will unpublish the site until another commit is made. |
Done. Please check the respective sites to see if they are still working. |
|
I have made various changes mentioned in the comment above and have marked them as completed. Ones not checked I did not do. |
Thank you @ahankinson, that's awesome! Shall we make a short announcement on MEI-L and Slack? |
Many thanks, the remaining changes are provided in #868 |
Due to the changes introduced in #776
Background:
The text was updated successfully, but these errors were encountered: