New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic wrapper for sysex write #32

Merged
merged 1 commit into from Jan 4, 2017

Conversation

Projects
None yet
2 participants
@jamesmunns
Copy link
Contributor

jamesmunns commented Jan 4, 2017

Hey, I added a wrapper for Pm_WriteSysEx. I tested it on my Novation Launchpad, and it works as intended.

I am not very familiar with PortMidi or MIDI in general, so let me know if I am missing something important.

I added a check for the terminator, because looking at the C code here: http://portmedia.sourceforge.net/portmidi/doxygen/portmidi_8c-source.html, it looks like PortMidi will happily write off the edge of the buffer until it hits a terminator.

@jamesmunns

This comment has been minimized.

Copy link
Contributor

jamesmunns commented Jan 4, 2017

This partially implements #16.

@musitdev musitdev merged commit d832568 into musitdev:master Jan 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment