1.9.3+ YAML compatibility #143

Merged
merged 5 commits into from Feb 18, 2014

Conversation

Projects
None yet
8 participants

No description provided.

Barry Allard added some commits Sep 24, 2012

steakknife referenced this pull request Sep 24, 2012

Closed

Fix for Ruby 1.9.3-rc1 #116

gcatlin commented Feb 3, 2013

Please merge!

Any chance this is going to be merged?

+1 on this, I got bit by this issue again.

+1 , getting sick of having to patch mustache on new deployments

jtara commented Jul 25, 2013

Shouldn't the test be for the existence of YAML.load_stream (and/or YAML/each_document), rather than for Ruby 1.9.3?

@locks locks added a commit that referenced this pull request Feb 18, 2014

@locks locks Merge pull request #143 from steakknife/develop
1.9.3+ YAML compatibility
4b1e24b

@locks locks merged commit 4b1e24b into mustache:master Feb 18, 2014

Owner

locks commented Feb 18, 2014

Merging this as in in favor of #116.

Member

bobthecow commented Feb 18, 2014

I'm with @jtara. Detect features, not versions.

Owner

locks commented Feb 18, 2014

1.8.7 support will have to be discussed going forward anyway, so this code will be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment