Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow Node v18.12.0 LTS w/ NPM v8.19.2 #533

Merged
merged 2 commits into from Jan 3, 2023
Merged

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Jan 3, 2023

No description provided.

@luwes luwes requested a review from a team as a code owner January 3, 2023 15:35
@luwes luwes self-assigned this Jan 3, 2023
@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 5:17PM (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 5:17PM (UTC)
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 5:17PM (UTC)
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 5:17PM (UTC)
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 5:17PM (UTC)

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #533 (5b311eb) into main (432358b) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b311eb differs from pull request most recent head 29be001. Consider uploading reports for the commit 29be001 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          26       26           
  Lines        6184     6184           
  Branches      266      266           
=======================================
  Hits         5140     5140           
  Misses       1043     1043           
  Partials        1        1           

package.json Outdated
"node": "^14.17.0 || ^16.13.0",
"npm": "^7.17.0 || ^8.1.0"
"node": "^14.17.0 || ^16.13.0 || ^18.12.0",
"npm": "^7.17.0 || ^8.1.0 || ^8.19.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I don't think ^8.19.2 is needed as ^8.1.0 should cover that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants