Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse: heredoc bodies can contain expansions #22

Closed
mvdan opened this issue Jul 6, 2016 · 1 comment
Closed

parse: heredoc bodies can contain expansions #22

mvdan opened this issue Jul 6, 2016 · 1 comment
Labels
bug

Comments

@mvdan
Copy link
Owner

mvdan commented Jul 6, 2016 

$ cat <<EOF
> $(echo foo)
> EOF
foo

Right now we're just reading lines and treaging everything as literals, as if it were in between single quotes. This is more like as if it were in between double quotes.
@mvdan mvdan added the bug label Jul 6, 2016
@mvdan
Copy link
Owner Author

mvdan commented Jul 6, 2016

This also means that Hdoc *Lit in ast.go is wrong.

mvdan added a commit that referenced this issue Jul 18, 2016
@mvdan
all: transition to heredocs being words
a99ea68 
Ground work towards fixing #22.
@mvdan mvdan closed this as completed in 54aaa35 Aug 5, 2016
@mvdan mvdan mentioned this issue Aug 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvdan