Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/mikebrock/mvel/issues/27 #84

Merged
merged 1 commit into from Feb 11, 2016

Conversation

@mkornipati
Copy link
Contributor

mkornipati commented Feb 10, 2016

We came across the problem mentioned in mikebrock/mvel#27

and unfortunately, we cannot move to latest version of MVEL2. We tried with below change and it works for us with Java 8. Is this something we can release part of 2.1.X releases, may be as 2.1.10.Final? And unfortunately, I am not finding any branch associated to 2.1. releases but can see tags. Please let me know if you are fine with this change but re-create PR against a different branch.

mariofusco added a commit that referenced this pull request Feb 11, 2016
Fix Java version recognition in ASMAccessorOptimizer
@mariofusco mariofusco merged commit bf54968 into mvel:master Feb 11, 2016
@mkornipati

This comment has been minimized.

Copy link
Contributor Author

mkornipati commented Feb 11, 2016

Thanks @mariofusco for merging this Pull Request. Is this fix can be released part of 2.1.X.Final releases? Let me know in case you want me to create a separate PR for a specific 2.1.x branches.

@jscattergood

This comment has been minimized.

Copy link

jscattergood commented Mar 24, 2016

@mariofusco We still use JBPM and Drools 5 and cannot upgrade due to version 6 because of dependencies. I have verified that @mkornipati 's fix solved our intermittent compilation issues with Java 8. Can this fix be backmerged to 2.1.X?

jscattergood added a commit to jscattergood/mvel that referenced this pull request Mar 24, 2016
@arun2arunraj

This comment has been minimized.

Copy link

arun2arunraj commented May 23, 2016

@jscattergood @mkornipati : Could you please tell me the steps involved to fix the issue ? We are facing the intermittent compilation error with JAVA 8. Any help would be much appreciated.

@jscattergood

This comment has been minimized.

Copy link

jscattergood commented May 23, 2016

@arun2arunraj You can see the changed file in this PR. If the fixed isn't merged into your version, then you need to create a fork of mvel repository, create a branch appropriate for yourself, merge the changes and build your own jar.

@rajmalarapu

This comment has been minimized.

Copy link

rajmalarapu commented Jan 20, 2017

Code within org.mvel2.optimizers.impl.asm.ASMAccessorOptimizer should be fixed as shown in below article:
http://copyrightdev.tumblr.com/post/146315831773/getting-drools-5x-to-operate-smoothly-with-java-8

@shaileshsingh9214

This comment has been minimized.

Copy link

shaileshsingh9214 commented Oct 25, 2017

Hi sir I am new to gradle and I am using maven as dependency Management tool how i will be able to achieve the same please enlighten me on the same.

@mkornipati

This comment has been minimized.

Copy link
Contributor Author

mkornipati commented Oct 27, 2017

@shaileshsingh9214 you can follow same practice in Maven too - https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html
exclude MVEL explictly for drools dependencies and include your patched MVEL

stephanborn pushed a commit to stephanborn/mvel that referenced this pull request Mar 13, 2019
Merge pull request mvel#84 from mkornipati/2.1.9.Final.Patch

Fix Java version recognition in ASMAccessorOptimizer

(cherry picked from commit bf54968)
@vikasbo

This comment has been minimized.

Copy link

vikasbo commented on 3141b15 May 13, 2019

@mkornipati I get mvel/src/main/java/org/mvel2/util/JITClassLoader.java:[49,33] error: method defineClass in class Unsafe cannot be applied to given types;
on packaging this project. Can you share instructions for java version for this build release? thanks

This comment has been minimized.

Copy link

vikasbo replied May 13, 2019

@mkornipati Does it require java version 1.5 and maven version 2 to build? Is it possible to download this jar directly?

@proudcandy

This comment has been minimized.

Copy link

proudcandy commented Jun 27, 2019

@mariofusco We still use JBPM and Drools 5 and cannot upgrade due to version 6 because of dependencies. I have verified that @mkornipati 's fix solved our intermittent compilation issues with Java 8. Can this fix be backmerged to 2.1.X?

I'm confused: Why the issues is interstitial. I'll be appreciate if you can explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.