New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip subdirs #10

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@kyzn
Contributor

kyzn commented Oct 31, 2017

Hi! Thanks for maintaining AnyEvent::Filesys::Notify! It was my assignment for CPAN Pull Request Challenge - October 2017.

I was going through your TODO list, and found out you wanted to add a flag to skip recursion. I implemented one, and added some tests to make sure it's running fine. I hope you find it useful! Let me know if you want me to update anything.

This PR will probably let us close RT ticket at https://rt.cpan.org/Public/Bug/Display.html?id=104714.

Thanks!

#cpan-prc #hacktoberfest

@mvgrimes

This comment has been minimized.

Show comment
Hide comment
@mvgrimes

mvgrimes Nov 2, 2017

Owner

Thanks @kyzn. This looks good. I particularly appreciate the tests.

We need to investigate the Travis failures before merging. It seems to be failing on older versions of perl (<5.18).

Owner

mvgrimes commented Nov 2, 2017

Thanks @kyzn. This looks good. I particularly appreciate the tests.

We need to investigate the Travis failures before merging. It seems to be failing on older versions of perl (<5.18).

@kyzn

This comment has been minimized.

Show comment
Hide comment
@kyzn

kyzn Nov 3, 2017

Contributor

Thanks for your kind comment @mvgrimes! You made a good point, I must have missed Travis failures. I'll take a look this weekend.

Contributor

kyzn commented Nov 3, 2017

Thanks for your kind comment @mvgrimes! You made a good point, I must have missed Travis failures. I'll take a look this weekend.

@kyzn

This comment has been minimized.

Show comment
Hide comment
@kyzn

kyzn Nov 5, 2017

Contributor
  • 5.12, 5.14, 5.16, 5.18 fails only the test I added. Looking into it now.
  • 5.21 fails because of a perlbrew issue, and everything falls apart after that. From logs:
$ perlbrew use 5.21

ERROR: The installation "5.21" is unknown.
Contributor

kyzn commented Nov 5, 2017

  • 5.12, 5.14, 5.16, 5.18 fails only the test I added. Looking into it now.
  • 5.21 fails because of a perlbrew issue, and everything falls apart after that. From logs:
$ perlbrew use 5.21

ERROR: The installation "5.21" is unknown.
@kyzn

This comment has been minimized.

Show comment
Hide comment
@kyzn

kyzn Nov 6, 2017

Contributor

Apparently I was missing a dot: I replaced qr// with qr/./ and it seems to work fine on 5.16.3 now.
I'm guessing "5.21" will still fail because it's not available on perlbrew.

Contributor

kyzn commented Nov 6, 2017

Apparently I was missing a dot: I replaced qr// with qr/./ and it seems to work fine on 5.16.3 now.
I'm guessing "5.21" will still fail because it's not available on perlbrew.

@mvgrimes mvgrimes merged commit dbf9f78 into mvgrimes:master Dec 4, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment