From 67a4aae0617433e672eb6f1b288ce2ad4d122697 Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 11:33:41 +0100
Subject: [PATCH 1/8] Indent according to coding style

---
 libyui-qt-pkg/src/YQPkgObjList.cc | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/libyui-qt-pkg/src/YQPkgObjList.cc b/libyui-qt-pkg/src/YQPkgObjList.cc
index 802bf8e1..c68b7b0f 100644
--- a/libyui-qt-pkg/src/YQPkgObjList.cc
+++ b/libyui-qt-pkg/src/YQPkgObjList.cc
@@ -394,7 +394,12 @@ YQPkgObjList::createActions()
     actionSetCurrentKeepInstalled	= createAction( S_KeepInstalled,	"[<], [-]"	);
     actionSetCurrentDelete		= createAction( S_Del,			"[-]"		);
     actionSetCurrentUpdate		= createAction( S_Update,		"[>], [+]"	);
-    actionSetCurrentUpdateForce		= createAction( _( "Update unconditionally" ),  statusIcon( S_Update, true )  ,statusIcon( S_Update, false ) , "", true ) ;
+
+    actionSetCurrentUpdateForce		= createAction( _( "Update unconditionally" ),
+                                                        statusIcon( S_Update, true ),
+                                                        statusIcon( S_Update, false ) ,
+                                                        "",
+                                                        true ) ;
 
 
 
@@ -557,7 +562,7 @@ void
 YQPkgObjList::updateActions( YQPkgObjListItem * item )
 {
     if ( !item)
-      item = dynamic_cast<YQPkgObjListItem *> ( currentItem() );
+        item = dynamic_cast<YQPkgObjListItem *> ( currentItem() );
 
     if ( item )
     {
@@ -799,6 +804,7 @@ YQPkgObjList::logExcludeStatistics()
     }
 }
 
+
 void
 YQPkgObjList::applyExcludeRules( QTreeWidgetItem * listViewItem )
 {
@@ -1655,7 +1661,7 @@ void YQPkgObjList::slotCustomContextMenu(const QPoint& pos)
 
         QMenu * contextMenu =
       	    ! item->selectable()->installedEmpty() ?
-              installedContextMenu() : notInstalledContextMenu();
+            installedContextMenu() : notInstalledContextMenu();
 
         if ( contextMenu )
             contextMenu->popup( viewport()->mapToGlobal( pos ) );

From bff32ea0f18a8f0161a54f8f0917207626285c97 Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 11:35:20 +0100
Subject: [PATCH 2/8] Indent according to coding style

---
 libyui-qt-pkg/src/YQPkgPatternList.cc | 184 +++++++++++++-------------
 1 file changed, 95 insertions(+), 89 deletions(-)

diff --git a/libyui-qt-pkg/src/YQPkgPatternList.cc b/libyui-qt-pkg/src/YQPkgPatternList.cc
index 8b1c3fe3..e33f8408 100644
--- a/libyui-qt-pkg/src/YQPkgPatternList.cc
+++ b/libyui-qt-pkg/src/YQPkgPatternList.cc
@@ -61,42 +61,45 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 using std::string;
 using std::set;
 
+
 class YQPkgPatternItemDelegate : public QItemDelegate
 {
-     YQPkgPatternList *_view;
+    YQPkgPatternList *_view;
+
 public:
-    YQPkgPatternItemDelegate( YQPkgPatternList *parent ) : QItemDelegate( parent ), _view( parent ) {
+
+    YQPkgPatternItemDelegate( YQPkgPatternList *parent ) : QItemDelegate( parent ), _view( parent )
+    {
     }
 
+
     virtual void paint ( QPainter * painter, const QStyleOptionViewItem & option, const QModelIndex & index ) const
     {
         painter->save();
 
         YQPkgPatternCategoryItem *citem = dynamic_cast<YQPkgPatternCategoryItem *>(_view->itemFromIndex(index));
+        
         // special painting for category items
         if ( citem )
         {
-            //std::cout << "printing category: " << index.column() << std::endl;
             QFont f = painter->font();
-            f.setWeight(QFont::Bold);
+            f.setWeight( QFont::Bold );
             QFontMetrics fm(f);
             f.setPixelSize( (int) ( fm.height() * 1.1 ) );
-            citem->setFont(_view->summaryCol(), f);
+            citem->setFont( _view->summaryCol(), f );
 
-            QItemDelegate::paint(painter, option, index);
+            QItemDelegate::paint( painter, option, index );
             painter->restore();
             return;
         }
 
-
-        YQPkgPatternListItem *item = dynamic_cast<YQPkgPatternListItem *>(_view->itemFromIndex(index));
+        YQPkgPatternListItem *item = dynamic_cast<YQPkgPatternListItem *>( _view->itemFromIndex( index ) );
+        
         if ( item )
         {
             //if ( index.column() == _view->howmanyCol() )
             if ( false )
             {
-                //std::cout << "printing percentage: " << index.column() << std::endl;
-
                 QColor background = option.palette.color(QPalette::Window);
                 painter->setBackground( background );
 
@@ -107,7 +110,7 @@ class YQPkgPatternItemDelegate : public QItemDelegate
                 QColor fillColor = option.palette.color(QPalette::Mid);
 
                 if ( percent > 100.0 )	percent = 100.0;
-                if ( percent < 0.0   )	percent = 0.0;
+                if ( percent < 0.0	 )	percent = 0.0;
                 int x = option.rect.left() + 1;
                 int y = option.rect.top() + 1;
                 int w = option.rect.width() - 2;
@@ -116,21 +119,19 @@ class YQPkgPatternItemDelegate : public QItemDelegate
                 if ( w > 0 )
                 {
                     fillWidth = (int) ( w * percent / 100.0 );
-                    //std::cout << "percent: " << percent << " fillw: " << fillWidth << " x: " << x << " y: " << y << "w: " << w << " h: " << h << std::endl;
 
                     // Fill the desired percentage.
 
-                   painter->fillRect( x, y,  fillWidth, h,
-                                      fillColor );
+                    painter->fillRect( x, y,  fillWidth, h, fillColor );
 
-                   QString percentageText;
+                    QString percentageText;
                     percentageText.sprintf("%d/%d", item->installedPackages(), item->totalPackages());
 
-		    painter->setPen( _view->palette().color( QPalette::Base ) );
-		    painter->drawText( QRect( x, y,
-					      w, h ),
-				       Qt::AlignHCenter, percentageText );
-                   painter->restore();
+                    painter->setPen( _view->palette().color( QPalette::Base ) );
+                    painter->drawText( QRect( x, y,
+                                              w, h ),
+                                       Qt::AlignHCenter, percentageText );
+                    painter->restore();
                 }
                 painter->restore();
                 return;
@@ -142,7 +143,6 @@ class YQPkgPatternItemDelegate : public QItemDelegate
                 painter->restore();
                 QItemDelegate::paint(painter, option, index);
             }
-
         }
     }
 };
@@ -176,8 +176,8 @@ YQPkgPatternList::YQPkgPatternList( QWidget * parent, bool autoFill, bool autoFi
 
     setIndentation(0);
 
-    setItemDelegateForColumn( _iconCol, new YQPkgPatternItemDelegate( this ) );
-    setItemDelegateForColumn( _statusCol, new YQPkgPatternItemDelegate( this ) );
+    setItemDelegateForColumn( _iconCol,    new YQPkgPatternItemDelegate( this ) );
+    setItemDelegateForColumn( _statusCol,  new YQPkgPatternItemDelegate( this ) );
     setItemDelegateForColumn( _summaryCol, new YQPkgPatternItemDelegate( this ) );
     //setItemDelegateForColumn( _howmanyCol, new YQPkgPatternItemDelegate(this) );
 
@@ -195,9 +195,9 @@ YQPkgPatternList::YQPkgPatternList( QWidget * parent, bool autoFill, bool autoFi
 
     setAllColumnsShowFocus( true );
 
-    header()->setSectionResizeMode( statusCol(), QHeaderView::Fixed );
+    header()->setSectionResizeMode( statusCol(),  QHeaderView::Fixed   );
     header()->setSectionResizeMode( summaryCol(), QHeaderView::Stretch );
-    header()->setSectionResizeMode( howmanyCol(), QHeaderView::Fixed );
+    header()->setSectionResizeMode( howmanyCol(), QHeaderView::Fixed   );
 
     header()->resizeSection( statusCol(), 25 );
     setColumnWidth( statusCol(), 25 );
@@ -210,8 +210,9 @@ YQPkgPatternList::YQPkgPatternList( QWidget * parent, bool autoFill, bool autoFi
 
     if ( autoFilter )
     {
-	connect( this, SIGNAL( currentItemChanged( QTreeWidgetItem *, QTreeWidgetItem * ) ),
-		 this, SLOT  ( filter()				   ) );
+	connect( this, SIGNAL( currentItemChanged( QTreeWidgetItem *,
+                                                   QTreeWidgetItem * ) ),
+		 this, SLOT  ( filter()		                       ) );
     }
 
     setIconSize(QSize(32,32));
@@ -223,6 +224,7 @@ YQPkgPatternList::YQPkgPatternList( QWidget * parent, bool autoFill, bool autoFi
 	fillList();
 	selectSomething();
     }
+    
     yuiDebug() << "Creating pattern list done" << std::endl;
 }
 
@@ -307,32 +309,32 @@ YQPkgPatternList::filter()
 
     if ( selection() )	// The seleted QListViewItem
     {
-        ZyppPattern zyppPattern = selection()->zyppPattern();
+	ZyppPattern zyppPattern = selection()->zyppPattern();
 
-        if ( zyppPattern )
-        {
-            int total = 0;
-            int installed = 0;
-
-            zypp::Pattern::Contents  c(zyppPattern->contents());
-            for ( zypp::Pattern::Contents::Selectable_iterator it = c.selectableBegin();
-                  it != c.selectableEnd();
-                  ++it )
-            {
-                ZyppPkg zyppPkg = tryCastToZyppPkg( (*it)->theObj() );
-                if ( zyppPkg )
-                {
-                    if ( (*it)->installedSize() > 0 )
-                        ++installed;
-                    ++total;
+	if ( zyppPattern )
+	{
+	    int total = 0;
+	    int installed = 0;
 
-                    emit filterMatch( *it, zyppPkg );
-                }
-            }
-            selection()->setInstalledPackages(installed);
-            selection()->setTotalPackages(total);
-            selection()->resetToolTip();
-        }
+	    zypp::Pattern::Contents  c(zyppPattern->contents());
+	    for ( zypp::Pattern::Contents::Selectable_iterator it = c.selectableBegin();
+		  it != c.selectableEnd();
+		  ++it )
+	    {
+		ZyppPkg zyppPkg = tryCastToZyppPkg( (*it)->theObj() );
+		if ( zyppPkg )
+		{
+		    if ( (*it)->installedSize() > 0 )
+			++installed;
+		    ++total;
+
+		    emit filterMatch( *it, zyppPkg );
+		}
+	    }
+	    selection()->setInstalledPackages(installed);
+	    selection()->setTotalPackages(total);
+	    selection()->resetToolTip();
+	}
     }
 
     emit filterFinished();
@@ -355,11 +357,11 @@ YQPkgPatternList::addPatternItem( ZyppSel	selectable,
 
     if ( cat )
     {
-        item = new YQPkgPatternListItem( this, cat, selectable, zyppPattern );
+	item = new YQPkgPatternListItem( this, cat, selectable, zyppPattern );
     }
     else
     {
-        item = new YQPkgPatternListItem( this, selectable, zyppPattern );
+	item = new YQPkgPatternListItem( this, selectable, zyppPattern );
     }
 
     resizeColumnToContents(_howmanyCol);
@@ -393,18 +395,18 @@ YQPkgPatternList::pkgObjClicked( int			button,
 
     if ( categoryItem )
     {
-        if ( button == Qt::LeftButton )
-        {
-            if ( col == 0 )
-            {
-                categoryItem->setExpanded( ! categoryItem->isExpanded() );
-            }
-        }
+	if ( button == Qt::LeftButton )
+	{
+	    if ( col == 0 )
+	    {
+		categoryItem->setExpanded( ! categoryItem->isExpanded() );
+	    }
+	}
     }
     else
     {
 
-        YQPkgObjList::pkgObjClicked( button, listViewItem, col, pos );
+	YQPkgObjList::pkgObjClicked( button, listViewItem, col, pos );
     }
 }
 
@@ -432,6 +434,7 @@ YQPkgPatternList::selectSomething()
 #endif
 }
 
+
 YQPkgPatternListItem::YQPkgPatternListItem( YQPkgPatternList *	patternList,
 					    ZyppSel		selectable,
 					    ZyppPattern		zyppPattern )
@@ -466,25 +469,25 @@ YQPkgPatternListItem::init()
 
     if (_zyppPattern)
     {
-        string icon = _zyppPattern->icon().asString();
-        // HACK most patterns have wrong default icon
-        if ( (icon == zypp::Pathname("yast-system").asString()) ||
-             icon.empty() )
-            icon = "pattern-generic";
+	string icon = _zyppPattern->icon().asString();
+	// HACK most patterns have wrong default icon
+	if ( (icon == zypp::Pathname("yast-system").asString()) ||
+	     icon.empty() )
+	    icon = "pattern-generic";
+
+
+	//std::cout << icon << " | "<< iconpath << std::endl;
+	QString iconName = QString::fromStdString(icon);
+	if ( QIcon::hasThemeIcon(iconName) )
+	{
+	    setIcon( _patternList->iconCol(), QIcon::fromTheme(iconName) );
+	}
+	else
+	{
+	    std::string iconpath = YQPackageSelector::iconPath(icon, 32);
+	    setIcon(_patternList->iconCol(), QIcon(QString(iconpath.c_str())));
+	}
 
-        
-        //std::cout << icon << " | "<< iconpath << std::endl;
-    QString iconName = QString::fromStdString(icon);
-    if ( QIcon::hasThemeIcon(iconName) )
-    {
-        setIcon( _patternList->iconCol(), QIcon::fromTheme(iconName) );
-    }
-    else
-    {
-        std::string iconpath = YQPackageSelector::iconPath(icon, 32);
-        setIcon(_patternList->iconCol(), QIcon(QString(iconpath.c_str())));
-    }
-        
 
     }
 
@@ -526,7 +529,7 @@ YQPkgPatternListItem::cycleStatus()
 	    break;
 
 	case S_AutoInstall:
-	    newStatus =  S_NoInst;
+	    newStatus =	 S_NoInst;
 	    break;
 
 	default:
@@ -560,12 +563,13 @@ YQPkgPatternListItem::resetToolTip()
 
     if ( totalPackages() > 0 )
     {
-        infoToolTip += ("<p>" + zypp::str::form("%d / %d", installedPackages(), totalPackages() ) + "</p>");
+	infoToolTip += ("<p>" + zypp::str::form("%d / %d", installedPackages(), totalPackages() ) + "</p>");
     }
 
     setToolTip(_patternList->summaryCol(), fromUTF8(infoToolTip));
 }
 
+
 void
 YQPkgPatternListItem::applyChanges()
 {
@@ -582,10 +586,10 @@ bool YQPkgPatternListItem::operator< ( const QTreeWidgetItem & otherListViewItem
 
     if ( _zyppPattern && otherPatternListitem && otherPatternListitem->zyppPattern() )
     {
-        if ( _zyppPattern->order() != otherPatternListitem->zyppPattern()->order() )
-            return _zyppPattern->order() < otherPatternListitem->zyppPattern()->order();
-        else
-            return _zyppPattern->name() < otherPatternListitem->zyppPattern()->name();
+	if ( _zyppPattern->order() != otherPatternListitem->zyppPattern()->order() )
+	    return _zyppPattern->order() < otherPatternListitem->zyppPattern()->order();
+	else
+	    return _zyppPattern->name() < otherPatternListitem->zyppPattern()->name();
     }
 
     const YQPkgPatternCategoryItem * otherCategoryItem = dynamic_cast<const YQPkgPatternCategoryItem *>(&otherListViewItem);
@@ -596,6 +600,7 @@ bool YQPkgPatternListItem::operator< ( const QTreeWidgetItem & otherListViewItem
     return QTreeWidgetItem::operator<( otherListViewItem );
 }
 
+
 YQPkgPatternCategoryItem::YQPkgPatternCategoryItem( YQPkgPatternList *	patternList,
 						    const QString &	category	)
     : QY2ListViewItem( patternList )
@@ -613,6 +618,7 @@ YQPkgPatternCategoryItem::~YQPkgPatternCategoryItem()
     // NOP
 }
 
+
 void
 YQPkgPatternCategoryItem::addPattern( ZyppPattern pattern )
 {
@@ -640,9 +646,9 @@ void
 YQPkgPatternCategoryItem::setTreeIcon()
 {
     setIcon( 0,
-             isExpanded() ?
-             YQIconPool::arrowDown() :
-             YQIconPool::arrowRight()   );
+	     isExpanded() ?
+	     YQIconPool::arrowDown() :
+	     YQIconPool::arrowRight()	);
 
 }
 
@@ -652,7 +658,7 @@ bool YQPkgPatternCategoryItem::operator< ( const QTreeWidgetItem & otherListView
     const YQPkgPatternCategoryItem * otherCategoryItem = dynamic_cast<const YQPkgPatternCategoryItem *>(&otherListViewItem);
 
     if ( _firstPattern && otherCategoryItem && otherCategoryItem->firstPattern() )
-        return _firstPattern->order() < otherCategoryItem->firstPattern()->order();
+	return _firstPattern->order() < otherCategoryItem->firstPattern()->order();
 
 
     const YQPkgPatternListItem * otherPatternListitem	 = dynamic_cast<const YQPkgPatternListItem *>(&otherListViewItem);

From 3ecc8af1ed9327e430f868f03292307c85607f38 Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 15:27:17 +0100
Subject: [PATCH 3/8] Removed leftovers from 10+ years old build system

---
 libyui-qt-pkg/src/YQPackageSelector.cc               | 1 -
 libyui-qt-pkg/src/YQPackageSelectorBase.cc           | 1 -
 libyui-qt-pkg/src/YQPatternSelector.cc               | 1 -
 libyui-qt-pkg/src/YQPkgChangeLogView.cc              | 1 -
 libyui-qt-pkg/src/YQPkgChangesDialog.cc              | 1 -
 libyui-qt-pkg/src/YQPkgConflictDialog.cc             | 1 -
 libyui-qt-pkg/src/YQPkgConflictList.cc               | 1 -
 libyui-qt-pkg/src/YQPkgDependenciesView.cc           | 1 -
 libyui-qt-pkg/src/YQPkgDescriptionDialog.cc          | 1 -
 libyui-qt-pkg/src/YQPkgDescriptionView.cc            | 1 -
 libyui-qt-pkg/src/YQPkgDiskUsageList.cc              | 1 -
 libyui-qt-pkg/src/YQPkgDiskUsageWarningDialog.cc     | 1 -
 libyui-qt-pkg/src/YQPkgFileListView.cc               | 1 -
 libyui-qt-pkg/src/YQPkgFilterTab.cc                  | 1 -
 libyui-qt-pkg/src/YQPkgGenericDetailsView.cc         | 1 -
 libyui-qt-pkg/src/YQPkgHistoryDialog.cc              | 1 -
 libyui-qt-pkg/src/YQPkgLangList.cc                   | 1 -
 libyui-qt-pkg/src/YQPkgList.cc                       | 1 -
 libyui-qt-pkg/src/YQPkgObjList.cc                    | 1 -
 libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc | 1 -
 libyui-qt-pkg/src/YQPkgPatchFilterView.cc            | 1 -
 libyui-qt-pkg/src/YQPkgPatchList.cc                  | 1 -
 libyui-qt-pkg/src/YQPkgPatternList.cc                | 1 -
 libyui-qt-pkg/src/YQPkgProductDialog.cc              | 1 -
 libyui-qt-pkg/src/YQPkgProductList.cc                | 1 -
 libyui-qt-pkg/src/YQPkgRepoFilterView.cc             | 1 -
 libyui-qt-pkg/src/YQPkgRepoList.cc                   | 1 -
 libyui-qt-pkg/src/YQPkgSearchFilterView.cc           | 1 -
 libyui-qt-pkg/src/YQPkgSecondaryFilterView.cc        | 1 -
 libyui-qt-pkg/src/YQPkgSelDescriptionView.cc         | 1 -
 libyui-qt-pkg/src/YQPkgSelList.cc                    | 1 -
 libyui-qt-pkg/src/YQPkgServiceFilterView.cc          | 1 -
 libyui-qt-pkg/src/YQPkgServiceList.cc                | 1 -
 libyui-qt-pkg/src/YQPkgStatusFilterView.cc           | 1 -
 libyui-qt-pkg/src/YQPkgTechnicalDetailsView.cc       | 1 -
 libyui-qt-pkg/src/YQPkgTextDialog.cc                 | 1 -
 libyui-qt-pkg/src/YQPkgUpdateProblemFilterView.cc    | 1 -
 libyui-qt-pkg/src/YQPkgVersionsView.cc               | 1 -
 libyui-qt-pkg/src/YQSimplePatchSelector.cc           | 1 -
 39 files changed, 39 deletions(-)

diff --git a/libyui-qt-pkg/src/YQPackageSelector.cc b/libyui-qt-pkg/src/YQPackageSelector.cc
index 6d50ab30..cb8fa45f 100644
--- a/libyui-qt-pkg/src/YQPackageSelector.cc
+++ b/libyui-qt-pkg/src/YQPackageSelector.cc
@@ -1850,4 +1850,3 @@ void YQPackageSelector::normalCursor()
 }
 
 
-#include "YQPackageSelector.moc"
diff --git a/libyui-qt-pkg/src/YQPackageSelectorBase.cc b/libyui-qt-pkg/src/YQPackageSelectorBase.cc
index 99da961d..70d1398d 100644
--- a/libyui-qt-pkg/src/YQPackageSelectorBase.cc
+++ b/libyui-qt-pkg/src/YQPackageSelectorBase.cc
@@ -514,4 +514,3 @@ YQPkgSelWmCloseHandler::filter( YEvent * event )
 }
 
 
-#include "YQPackageSelectorBase.moc"
diff --git a/libyui-qt-pkg/src/YQPatternSelector.cc b/libyui-qt-pkg/src/YQPatternSelector.cc
index e11244e7..6a0c1904 100644
--- a/libyui-qt-pkg/src/YQPatternSelector.cc
+++ b/libyui-qt-pkg/src/YQPatternSelector.cc
@@ -341,4 +341,3 @@ YQPatternSelector::debugTrace()
 
 
 
-#include "YQPatternSelector.moc"
diff --git a/libyui-qt-pkg/src/YQPkgChangeLogView.cc b/libyui-qt-pkg/src/YQPkgChangeLogView.cc
index 01ddc522..8f5448ec 100644
--- a/libyui-qt-pkg/src/YQPkgChangeLogView.cc
+++ b/libyui-qt-pkg/src/YQPkgChangeLogView.cc
@@ -148,4 +148,3 @@ QString YQPkgChangeLogView::notDisplayedChanges(int missing, const std::string &
     return msg.arg(QString::number(missing), cmd);
 }
 
-#include "YQPkgChangeLogView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgChangesDialog.cc b/libyui-qt-pkg/src/YQPkgChangesDialog.cc
index 7489a999..368790fe 100644
--- a/libyui-qt-pkg/src/YQPkgChangesDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgChangesDialog.cc
@@ -416,4 +416,3 @@ YQPkgUnsupportedPackagesDialog::showUnsupportedPackagesDialog( QWidget *	parent,
 }
 
 
-#include "YQPkgChangesDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgConflictDialog.cc b/libyui-qt-pkg/src/YQPkgConflictDialog.cc
index 3d50ee15..77510b59 100644
--- a/libyui-qt-pkg/src/YQPkgConflictDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgConflictDialog.cc
@@ -444,4 +444,3 @@ YQPkgConflictDialog::keyPressEvent( QKeyEvent * event )
 
 
 
-#include "YQPkgConflictDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgConflictList.cc b/libyui-qt-pkg/src/YQPkgConflictList.cc
index 3d516355..9bdd44df 100644
--- a/libyui-qt-pkg/src/YQPkgConflictList.cc
+++ b/libyui-qt-pkg/src/YQPkgConflictList.cc
@@ -416,4 +416,3 @@ YQPkgConflict::saveToFile( QFile &file ) const
     file.write( "\n\n" );
 }
 
-#include "YQPkgConflictList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgDependenciesView.cc b/libyui-qt-pkg/src/YQPkgDependenciesView.cc
index 3b9db2c4..ae1e9080 100644
--- a/libyui-qt-pkg/src/YQPkgDependenciesView.cc
+++ b/libyui-qt-pkg/src/YQPkgDependenciesView.cc
@@ -202,4 +202,3 @@ YQPkgDependenciesView::htmlLines( const zypp::Capabilities & capSet )
 }
 
 
-#include "YQPkgDependenciesView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgDescriptionDialog.cc b/libyui-qt-pkg/src/YQPkgDescriptionDialog.cc
index 6863ad07..676383cb 100644
--- a/libyui-qt-pkg/src/YQPkgDescriptionDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgDescriptionDialog.cc
@@ -199,4 +199,3 @@ YQPkgDescriptionDialog::showDescriptionDialog( const QString & pkgName )
 
 
 
-#include "YQPkgDescriptionDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgDescriptionView.cc b/libyui-qt-pkg/src/YQPkgDescriptionView.cc
index d5fd8508..b3734aff 100644
--- a/libyui-qt-pkg/src/YQPkgDescriptionView.cc
+++ b/libyui-qt-pkg/src/YQPkgDescriptionView.cc
@@ -359,4 +359,3 @@ void YQPkgDescriptionView::initLang()
 }
 
 
-#include "YQPkgDescriptionView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgDiskUsageList.cc b/libyui-qt-pkg/src/YQPkgDiskUsageList.cc
index 5ca7cd01..b04f7abe 100644
--- a/libyui-qt-pkg/src/YQPkgDiskUsageList.cc
+++ b/libyui-qt-pkg/src/YQPkgDiskUsageList.cc
@@ -428,4 +428,3 @@ YQPkgWarningRangeNotifier::needWarning() const
 
 
 
-#include "YQPkgDiskUsageList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgDiskUsageWarningDialog.cc b/libyui-qt-pkg/src/YQPkgDiskUsageWarningDialog.cc
index 240113f6..01b83237 100644
--- a/libyui-qt-pkg/src/YQPkgDiskUsageWarningDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgDiskUsageWarningDialog.cc
@@ -180,4 +180,3 @@ YQPkgDiskUsageWarningDialog::diskUsageWarning( const QString & 	message,
 
 
 
-#include "YQPkgDiskUsageWarningDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgFileListView.cc b/libyui-qt-pkg/src/YQPkgFileListView.cc
index a6c2d242..193df288 100644
--- a/libyui-qt-pkg/src/YQPkgFileListView.cc
+++ b/libyui-qt-pkg/src/YQPkgFileListView.cc
@@ -134,4 +134,3 @@ QString YQPkgFileListView::formatFileList( const list<string> & fileList ) const
 }
 
 
-#include "YQPkgFileListView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgFilterTab.cc b/libyui-qt-pkg/src/YQPkgFilterTab.cc
index 6a915f1b..6ab515e2 100644
--- a/libyui-qt-pkg/src/YQPkgFilterTab.cc
+++ b/libyui-qt-pkg/src/YQPkgFilterTab.cc
@@ -728,4 +728,3 @@ YQPkgFilterTab::saveSettings()
 
 
 
-#include "YQPkgFilterTab.moc"
diff --git a/libyui-qt-pkg/src/YQPkgGenericDetailsView.cc b/libyui-qt-pkg/src/YQPkgGenericDetailsView.cc
index df54a3b9..3163c03e 100644
--- a/libyui-qt-pkg/src/YQPkgGenericDetailsView.cc
+++ b/libyui-qt-pkg/src/YQPkgGenericDetailsView.cc
@@ -261,4 +261,3 @@ YQPkgGenericDetailsView::hcell( QString contents )
 }
 
 
-#include "YQPkgGenericDetailsView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgHistoryDialog.cc b/libyui-qt-pkg/src/YQPkgHistoryDialog.cc
index c7af49b5..e00aeae2 100644
--- a/libyui-qt-pkg/src/YQPkgHistoryDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgHistoryDialog.cc
@@ -319,4 +319,3 @@ YQPkgHistoryDialog::moveToAction ()
     }
 }
 
-#include "YQPkgHistoryDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgLangList.cc b/libyui-qt-pkg/src/YQPkgLangList.cc
index 2b5dce94..a6967e3e 100644
--- a/libyui-qt-pkg/src/YQPkgLangList.cc
+++ b/libyui-qt-pkg/src/YQPkgLangList.cc
@@ -330,4 +330,3 @@ bool YQPkgLangListItem::operator<( const QTreeWidgetItem & otherListViewItem ) c
 
     return QY2ListViewItem::operator<( otherListViewItem );
 }
-#include "YQPkgLangList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgList.cc b/libyui-qt-pkg/src/YQPkgList.cc
index a6386029..56202a47 100644
--- a/libyui-qt-pkg/src/YQPkgList.cc
+++ b/libyui-qt-pkg/src/YQPkgList.cc
@@ -965,4 +965,3 @@ bool YQPkgListItem::operator< ( const QTreeWidgetItem & otherListViewItem ) cons
     return YQPkgObjListItem::operator<( otherListViewItem );
 }
 
-#include "YQPkgList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgObjList.cc b/libyui-qt-pkg/src/YQPkgObjList.cc
index c68b7b0f..fb318128 100644
--- a/libyui-qt-pkg/src/YQPkgObjList.cc
+++ b/libyui-qt-pkg/src/YQPkgObjList.cc
@@ -1681,4 +1681,3 @@ QTreeWidgetItem * YQPkgObjList::ExcludedItems::oldParentItem( QTreeWidgetItem *
 
 
 
-#include "YQPkgObjList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc b/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc
index 8151fd1b..3a0eefe5 100644
--- a/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc
@@ -462,4 +462,3 @@ YQPkgPackageKitGroup::operator< ( const QTreeWidgetItem & otherListViewItem ) co
 }
 
 
-#include "YQPkgPackageKitGroupsFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgPatchFilterView.cc b/libyui-qt-pkg/src/YQPkgPatchFilterView.cc
index c95548e0..8f662b99 100644
--- a/libyui-qt-pkg/src/YQPkgPatchFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgPatchFilterView.cc
@@ -225,4 +225,3 @@ YQPkgPatchFilterView::fillPatchList()
 }
 
 
-#include "YQPkgPatchFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgPatchList.cc b/libyui-qt-pkg/src/YQPkgPatchList.cc
index 5b999f48..64643a10 100644
--- a/libyui-qt-pkg/src/YQPkgPatchList.cc
+++ b/libyui-qt-pkg/src/YQPkgPatchList.cc
@@ -672,4 +672,3 @@ bool YQPkgPatchCategoryItem::operator< ( const QTreeWidgetItem & otherListViewIt
 
 
 
-#include "YQPkgPatchList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgPatternList.cc b/libyui-qt-pkg/src/YQPkgPatternList.cc
index e33f8408..facd7306 100644
--- a/libyui-qt-pkg/src/YQPkgPatternList.cc
+++ b/libyui-qt-pkg/src/YQPkgPatternList.cc
@@ -671,4 +671,3 @@ bool YQPkgPatternCategoryItem::operator< ( const QTreeWidgetItem & otherListView
 
 
 
-#include "YQPkgPatternList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgProductDialog.cc b/libyui-qt-pkg/src/YQPkgProductDialog.cc
index 93dfd7d3..53842b14 100644
--- a/libyui-qt-pkg/src/YQPkgProductDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgProductDialog.cc
@@ -177,4 +177,3 @@ YQPkgProductDialog::showProductDialog( QWidget* parent)
 
 
 
-#include "YQPkgProductDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgProductList.cc b/libyui-qt-pkg/src/YQPkgProductList.cc
index aa44e8f0..79b1e4d7 100644
--- a/libyui-qt-pkg/src/YQPkgProductList.cc
+++ b/libyui-qt-pkg/src/YQPkgProductList.cc
@@ -173,4 +173,3 @@ YQPkgProductListItem::applyChanges()
 
 
 
-#include "YQPkgProductList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgRepoFilterView.cc b/libyui-qt-pkg/src/YQPkgRepoFilterView.cc
index 5b4c5f69..94ebe455 100644
--- a/libyui-qt-pkg/src/YQPkgRepoFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgRepoFilterView.cc
@@ -91,4 +91,3 @@ void YQPkgRepoFilterView::primaryFilterIfVisible()
     _repoList->filterIfVisible();
 }
 
-#include "YQPkgRepoFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgRepoList.cc b/libyui-qt-pkg/src/YQPkgRepoList.cc
index f6adf9bd..a87754a6 100644
--- a/libyui-qt-pkg/src/YQPkgRepoList.cc
+++ b/libyui-qt-pkg/src/YQPkgRepoList.cc
@@ -297,4 +297,3 @@ YQPkgRepoListItem::operator< ( const QTreeWidgetItem & other ) const
     return zyppRepo().info().name() < otherItem->zyppRepo().info().name();
 }
 
-#include "YQPkgRepoList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgSearchFilterView.cc b/libyui-qt-pkg/src/YQPkgSearchFilterView.cc
index defc6bb7..fe0186a7 100644
--- a/libyui-qt-pkg/src/YQPkgSearchFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgSearchFilterView.cc
@@ -464,4 +464,3 @@ YQPkgSearchFilterView::check( const zypp::Capabilities& capSet, const QRegExp &
     return false;
 }
 
-#include "YQPkgSearchFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgSecondaryFilterView.cc b/libyui-qt-pkg/src/YQPkgSecondaryFilterView.cc
index 09ed1b48..8dd3058b 100644
--- a/libyui-qt-pkg/src/YQPkgSecondaryFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgSecondaryFilterView.cc
@@ -193,4 +193,3 @@ YQPkgSecondaryFilterView::secondaryFilterMatch( ZyppSel	selectable,
 	return true;
 }
 
-#include "YQPkgSecondaryFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgSelDescriptionView.cc b/libyui-qt-pkg/src/YQPkgSelDescriptionView.cc
index 97d648ec..9843e414 100644
--- a/libyui-qt-pkg/src/YQPkgSelDescriptionView.cc
+++ b/libyui-qt-pkg/src/YQPkgSelDescriptionView.cc
@@ -191,4 +191,3 @@ YQPkgSelDescriptionView::findIcon( const QString & icon ) const
 }
 
 
-#include "YQPkgSelDescriptionView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgSelList.cc b/libyui-qt-pkg/src/YQPkgSelList.cc
index 8e20f269..c805d7bc 100644
--- a/libyui-qt-pkg/src/YQPkgSelList.cc
+++ b/libyui-qt-pkg/src/YQPkgSelList.cc
@@ -256,4 +256,3 @@ YQPkgSelListItem::compare( QTreeWidgetItem *	otherListViewItem,
 
 
 
-#include "YQPkgSelList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgServiceFilterView.cc b/libyui-qt-pkg/src/YQPkgServiceFilterView.cc
index f346a6d3..f9fd9b52 100644
--- a/libyui-qt-pkg/src/YQPkgServiceFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgServiceFilterView.cc
@@ -63,4 +63,3 @@ bool YQPkgServiceFilterView::any_service()
 	return ret;
 }
 
-#include "YQPkgServiceFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgServiceList.cc b/libyui-qt-pkg/src/YQPkgServiceList.cc
index 1ac8c557..cca23dc3 100644
--- a/libyui-qt-pkg/src/YQPkgServiceList.cc
+++ b/libyui-qt-pkg/src/YQPkgServiceList.cc
@@ -248,4 +248,3 @@ YQPkgServiceListItem::operator< ( const QTreeWidgetItem & other ) const
     return QString::compare(fromUTF8(zyppServiceName()), fromUTF8(otherItem->zyppServiceName()), Qt::CaseInsensitive) < 0;
 }
 
-#include "YQPkgServiceList.moc"
diff --git a/libyui-qt-pkg/src/YQPkgStatusFilterView.cc b/libyui-qt-pkg/src/YQPkgStatusFilterView.cc
index 00ca2211..90e7707b 100644
--- a/libyui-qt-pkg/src/YQPkgStatusFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgStatusFilterView.cc
@@ -313,4 +313,3 @@ void YQPkgStatusFilterView::showNotInstalled()
 
 
 
-#include "YQPkgStatusFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgTechnicalDetailsView.cc b/libyui-qt-pkg/src/YQPkgTechnicalDetailsView.cc
index 2f07edec..bd9d3fdc 100644
--- a/libyui-qt-pkg/src/YQPkgTechnicalDetailsView.cc
+++ b/libyui-qt-pkg/src/YQPkgTechnicalDetailsView.cc
@@ -218,4 +218,3 @@ YQPkgTechnicalDetailsView::complexTable( ZyppSel	selectable,
 }
 
 
-#include "YQPkgTechnicalDetailsView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgTextDialog.cc b/libyui-qt-pkg/src/YQPkgTextDialog.cc
index 1831771f..9d9e5589 100644
--- a/libyui-qt-pkg/src/YQPkgTextDialog.cc
+++ b/libyui-qt-pkg/src/YQPkgTextDialog.cc
@@ -350,4 +350,3 @@ YQPkgTextDialog::htmlHeading( ZyppSel selectable )
 
 
 
-#include "YQPkgTextDialog.moc"
diff --git a/libyui-qt-pkg/src/YQPkgUpdateProblemFilterView.cc b/libyui-qt-pkg/src/YQPkgUpdateProblemFilterView.cc
index 51fbfd96..f277f778 100644
--- a/libyui-qt-pkg/src/YQPkgUpdateProblemFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgUpdateProblemFilterView.cc
@@ -133,4 +133,3 @@ YQPkgUpdateProblemFilterView::haveProblematicPackages()
 }
 
 
-#include "YQPkgUpdateProblemFilterView.moc"
diff --git a/libyui-qt-pkg/src/YQPkgVersionsView.cc b/libyui-qt-pkg/src/YQPkgVersionsView.cc
index 731b84c0..eae6e4ce 100644
--- a/libyui-qt-pkg/src/YQPkgVersionsView.cc
+++ b/libyui-qt-pkg/src/YQPkgVersionsView.cc
@@ -709,4 +709,3 @@ QPixmap YQPkgMultiVersion::statusIcon( ZyppStatus status )
 
 
 
-#include "YQPkgVersionsView.moc"
diff --git a/libyui-qt-pkg/src/YQSimplePatchSelector.cc b/libyui-qt-pkg/src/YQSimplePatchSelector.cc
index 42ca2a39..7e4b712e 100644
--- a/libyui-qt-pkg/src/YQSimplePatchSelector.cc
+++ b/libyui-qt-pkg/src/YQSimplePatchSelector.cc
@@ -280,4 +280,3 @@ YQSimplePatchSelector::debugTrace()
 
 
 
-#include "YQSimplePatchSelector.moc"

From 806aceb90a4617fb55ce05332b645f6a1b7198e8 Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 16:15:46 +0100
Subject: [PATCH 4/8] Better error handling for missing icons

---
 libyui-qt-pkg/src/YQIconPool.cc | 48 ++++++++++++++++++++++++++-------
 libyui-qt-pkg/src/YQIconPool.h  | 20 +++++++++-----
 2 files changed, 53 insertions(+), 15 deletions(-)

diff --git a/libyui-qt-pkg/src/YQIconPool.cc b/libyui-qt-pkg/src/YQIconPool.cc
index 4e031f11..2f1bbed4 100644
--- a/libyui-qt-pkg/src/YQIconPool.cc
+++ b/libyui-qt-pkg/src/YQIconPool.cc
@@ -42,9 +42,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #define YUILogComponent "qt-ui"
 #include "YUILog.h"
+#include "utf8.h"
 
 #include "YQIconPool.h"
 
+using std::endl;
+
 
 
 YQIconPool * YQIconPool::_iconPool = 0;
@@ -113,19 +116,46 @@ YQIconPool::cachedIcon( const QString icon_name, const bool enabled )
 
     if ( !iconPixmap )
     {
-        if ( QIcon::hasThemeIcon(icon_name) )
-        {
-            QIcon icon = QIcon::fromTheme(icon_name, QIcon( ":/" + icon_name ));
-            iconPixmap = icon.pixmap(QSize(16,16), enabled ? QIcon::Normal : QIcon::Disabled);
-        }
-        else
+        iconPixmap = loadIcon( icon_name, enabled );
+
+        if ( !iconPixmap )
         {
-            QIcon icon = QIcon( ":/" + icon_name );
-            iconPixmap = icon.pixmap(QSize(16,16), enabled ? QIcon::Normal : QIcon::Disabled);
+            // Create an icon for the cache to avoid more than one complaint
+            // and to have a clearly visible error icon (a small red square)
+            iconPixmap = QPixmap( 8, 8 );
+            iconPixmap.fill( Qt::red );
         }
     }
 
-    _iconCache.insert( icon_name + enabled, iconPixmap);
+    _iconCache.insert( icon_name + enabled, iconPixmap );
+
+    return iconPixmap;
+}
+
+
+QPixmap
+YQIconPool::loadIcon( const QString icon_name, const bool enabled )
+{
+    QPixmap iconPixmap = _iconCache[ icon_name + enabled ];
+
+    if ( QIcon::hasThemeIcon( icon_name ) )
+    {
+        yuiDebug() << "Loading theme icon " << icon_name << endl;
+
+        QIcon icon = QIcon::fromTheme( icon_name, QIcon( ":/" + icon_name ) );
+        iconPixmap = icon.pixmap( QSize( 16, 16 ), enabled ? QIcon::Normal : QIcon::Disabled );
+    }
+    else
+    {
+        yuiDebug() << "Loading built-in icon " << icon_name << endl;
+
+        QIcon icon = QIcon( ":/" + icon_name );
+        iconPixmap = icon.pixmap( QSize( 16, 16 ), enabled ? QIcon::Normal : QIcon::Disabled );
+    }
+
+    if ( !iconPixmap )
+        yuiError() << "Could not load icon " << icon_name << endl;
+
     return iconPixmap;
 }
 
diff --git a/libyui-qt-pkg/src/YQIconPool.h b/libyui-qt-pkg/src/YQIconPool.h
index e3edfd44..588a9ecb 100644
--- a/libyui-qt-pkg/src/YQIconPool.h
+++ b/libyui-qt-pkg/src/YQIconPool.h
@@ -70,12 +70,12 @@ class YQIconPool
     static QPixmap disabledPkgProtected();
     static QPixmap disabledPkgTaboo();
     static QPixmap disabledPkgUpdate();
-    
+
     static QPixmap normalPkgConflict();
 
     static QPixmap treePlus();
     static QPixmap treeMinus();
-    
+
     static QPixmap warningSign();
     static QPixmap pkgSatisfied();
 
@@ -92,12 +92,20 @@ class YQIconPool
     static YQIconPool * iconPool();
 
     /**
-     * Return the cached icon for 'xpm_data' ( an included XPM file ).
-     * If the icon isn't in the cache yet, create it and store it in the
-     * cache.
+     * Return the cached icon for 'icon_name'. If the icon isn't in the cache
+     * yet, load it and store it in the cache.
+     *
+     * Return a red square as an error icon if there is no icon by that name.
      **/
     QPixmap cachedIcon(const QString icon_name, const bool enabled );
 
+    /**
+     * Load the icon for 'icon_name' from the icon theme or, if that fails,
+     * from the compiled-in icons (using the Qt resource system). Return a null
+     * pixmap if there is no such icon.
+     **/
+    QPixmap loadIcon( const QString icon_name, const bool enabled );
+
 private:
 
     /**
@@ -111,7 +119,7 @@ class YQIconPool
      **/
     virtual ~YQIconPool();
 
-    
+
     //
     // Data members
     //

From a79d846ad08fda1854dd220f5c48c0fe75ca7330 Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 16:19:34 +0100
Subject: [PATCH 5/8] Ignore generated stuff

---
 libyui-qt-pkg/.gitignore | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libyui-qt-pkg/.gitignore b/libyui-qt-pkg/.gitignore
index f89ce3bf..e125466a 100644
--- a/libyui-qt-pkg/.gitignore
+++ b/libyui-qt-pkg/.gitignore
@@ -41,12 +41,18 @@ CMakeCache.txt
 CMakeFiles
 /CMakeLists.txt
 Makefile
-cmake_install.cmake
 install_manifest.txt
+**/*.cmake
 
 # CMake project-bindir
 build*/
 
+# Misc
+CMakeDoxyfile.in
+Doxyfile
+libyui-qt-pkg.pc
+src/yui-qt-pkg_autogen
+
 # Archives
 # It's better to unpack these files and commit the raw source because
 # git has its own built in compression methods.

From 4494c6fe4bb443cbe6b89ab2c62b76f681ba655d Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 16:23:28 +0100
Subject: [PATCH 6/8] Version bump and change log

---
 libyui-qt-pkg/VERSION.cmake                  | 2 +-
 libyui-qt-pkg/package/libyui-qt-pkg-doc.spec | 2 +-
 libyui-qt-pkg/package/libyui-qt-pkg.changes  | 6 ++++++
 libyui-qt-pkg/package/libyui-qt-pkg.spec     | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/libyui-qt-pkg/VERSION.cmake b/libyui-qt-pkg/VERSION.cmake
index 30c49c0b..44b9c3bd 100644
--- a/libyui-qt-pkg/VERSION.cmake
+++ b/libyui-qt-pkg/VERSION.cmake
@@ -1,6 +1,6 @@
 SET( VERSION_MAJOR "2" )
 SET( VERSION_MINOR "45" )
-SET( VERSION_PATCH "22" )
+SET( VERSION_PATCH "23" )
 SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}" )
 
 ##### This is need for the libyui core, ONLY.
diff --git a/libyui-qt-pkg/package/libyui-qt-pkg-doc.spec b/libyui-qt-pkg/package/libyui-qt-pkg-doc.spec
index a3adecfa..dd3b41e5 100644
--- a/libyui-qt-pkg/package/libyui-qt-pkg-doc.spec
+++ b/libyui-qt-pkg/package/libyui-qt-pkg-doc.spec
@@ -20,7 +20,7 @@
 %define so_version 9
 
 Name:           %{parent}-doc
-Version:        2.45.22
+Version:        2.45.23
 Release:        0
 Source:         %{parent}-%{version}.tar.bz2
 
diff --git a/libyui-qt-pkg/package/libyui-qt-pkg.changes b/libyui-qt-pkg/package/libyui-qt-pkg.changes
index 6c789152..e2d9eba6 100644
--- a/libyui-qt-pkg/package/libyui-qt-pkg.changes
+++ b/libyui-qt-pkg/package/libyui-qt-pkg.changes
@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Tue Nov  6 15:21:12 UTC 2018 - Stefan Hundhammer <shundhammer@suse.com>
+
+- Better error handling for missing icons (bsc#1114654)
+- 2.45.23
+
 -------------------------------------------------------------------
 Mon Oct 29 06:00:36 UTC 2018 - Stasiek Michalski <hellcp@mailbox.org>
 
diff --git a/libyui-qt-pkg/package/libyui-qt-pkg.spec b/libyui-qt-pkg/package/libyui-qt-pkg.spec
index 7f794054..91e6568c 100644
--- a/libyui-qt-pkg/package/libyui-qt-pkg.spec
+++ b/libyui-qt-pkg/package/libyui-qt-pkg.spec
@@ -17,7 +17,7 @@
 
 
 Name:           libyui-qt-pkg
-Version:        2.45.22
+Version:        2.45.23
 Release:        0
 Source:         %{name}-%{version}.tar.bz2
 

From 6db05566bec74a1a7c065aee871506caaf6a0212 Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 17:11:13 +0100
Subject: [PATCH 7/8] Better change log message

---
 libyui-qt-pkg/package/libyui-qt-pkg.changes | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libyui-qt-pkg/package/libyui-qt-pkg.changes b/libyui-qt-pkg/package/libyui-qt-pkg.changes
index e2d9eba6..416fcf73 100644
--- a/libyui-qt-pkg/package/libyui-qt-pkg.changes
+++ b/libyui-qt-pkg/package/libyui-qt-pkg.changes
@@ -1,7 +1,9 @@
 -------------------------------------------------------------------
 Tue Nov  6 15:21:12 UTC 2018 - Stefan Hundhammer <shundhammer@suse.com>
 
-- Better error handling for missing icons (bsc#1114654)
+- Better error handling for missing icons (bsc#1114654):
+  Error message in the y2log plus displaying a small red square for
+  missing icons.
 - 2.45.23
 
 -------------------------------------------------------------------

From b1668413d4f3ff324d2e667346e897f0a8ab530a Mon Sep 17 00:00:00 2001
From: Stefan Hundhammer <shundhammer@suse.de>
Date: Tue, 6 Nov 2018 17:12:33 +0100
Subject: [PATCH 8/8] Removed cruft

---
 libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc | 2 --
 libyui-qt-pkg/src/YQPkgPatternList.cc                | 5 -----
 2 files changed, 7 deletions(-)

diff --git a/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc b/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc
index 3a0eefe5..442ee670 100644
--- a/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc
+++ b/libyui-qt-pkg/src/YQPkgPackageKitGroupsFilterView.cc
@@ -232,8 +232,6 @@ YQPkgPackageKitGroupsFilterView::fillGroups()
 		group = itg->second;
 	    }
 
-	    //std::cout << it.asString() << std::endl;
-
 	    if ( _groupsMap.find(group) == _groupsMap.end() )
 	    {
 		_groupsMap[group] =  new YQPkgPackageKitGroup( this, group );
diff --git a/libyui-qt-pkg/src/YQPkgPatternList.cc b/libyui-qt-pkg/src/YQPkgPatternList.cc
index facd7306..83b1034f 100644
--- a/libyui-qt-pkg/src/YQPkgPatternList.cc
+++ b/libyui-qt-pkg/src/YQPkgPatternList.cc
@@ -139,7 +139,6 @@ class YQPkgPatternItemDelegate : public QItemDelegate
             }
             else
             {
-                //std::cout << "printing other: " << index.column() << std::endl;
                 painter->restore();
                 QItemDelegate::paint(painter, option, index);
             }
@@ -476,7 +475,6 @@ YQPkgPatternListItem::init()
 	    icon = "pattern-generic";
 
 
-	//std::cout << icon << " | "<< iconpath << std::endl;
 	QString iconName = QString::fromStdString(icon);
 	if ( QIcon::hasThemeIcon(iconName) )
 	{
@@ -581,9 +579,6 @@ bool YQPkgPatternListItem::operator< ( const QTreeWidgetItem & otherListViewItem
 {
     const YQPkgPatternListItem * otherPatternListitem	 = dynamic_cast<const YQPkgPatternListItem     *>(&otherListViewItem);
 
-    //std::cout << _zyppPattern->order()<< " | " << otherPatternListitem->zyppPattern()->order() << std::endl;
-
-
     if ( _zyppPattern && otherPatternListitem && otherPatternListitem->zyppPattern() )
     {
 	if ( _zyppPattern->order() != otherPatternListitem->zyppPattern()->order() )