Skip to content

ProxyObjectInterface#on_signal does not mimic ProxyObject#on_signal #31

mvidner opened this Issue Oct 4, 2012 · 0 comments

1 participant

mvidner commented Oct 4, 2012

ProxyObject#on_signal(name, &block) uses default_interface. When I want to use a non-default one, via ProxyObjectInterface#on_signal(bus,name, &block) I stupidly need to specify the bus too.

The API of PO and POI should reflect the fact that an object is almost entirely an aggregation of its interfaces, so their methods should have the same Ruby signatures; in this case #on_signal(name, &block)

@mvidner mvidner pushed a commit that referenced this issue Nov 6, 2012
@stoffie stoffie Use same args signatures for PO#on_signal and POI#on_signal
Fixes issue #31;
ProxyObjectInterface#on_signal shares now the arguments signature whit
ProxyObject#on_signal and can be used without specifying explicitly the
bus parameter, since the POI itself already owns the reference of the
bus is being used on.
@mvidner mvidner added a commit that closed this issue Nov 6, 2012
@mvidner doc: no need to mention an irregularity with on_signal; fixes #31.
amended the linked method doc not to specify a return value
@mvidner mvidner closed this in 5ea58ff Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.