update to bevy 0.9 dev #127
Conversation
| impl Deref for EguiRenderOutputContainer { | ||
| type Target = HashMap<WindowId, EguiRenderOutput>; | ||
|
|
||
| fn deref(&self) -> &Self::Target { | ||
| &self.0 | ||
| } | ||
| } |
There was a problem hiding this comment.
You can actually just use Bevy's Deref and DerefMut derives to achieve this.
| world.insert_resource(EguiRenderInputContainer( | ||
| HashMap::<WindowId, EguiInput>::default(), | ||
| )); |
There was a problem hiding this comment.
I would just make all these new resources derive Default. Then you can just do EguiRenderInputContainer::default() (or even world.init_resource::<EguiRenderInputContainer>()).
There was a problem hiding this comment.
And will also make it possible to initialize resources if some users decide not to add the egui plugin, by adding the resources and systems manually (with an intention to replace some of them).
| @@ -229,6 +233,7 @@ pub fn process_input( | |||
| if !event.char.is_control() { | |||
| input_resources | |||
| .egui_input | |||
| .0 | |||
There was a problem hiding this comment.
These .0's won't be needed if you derive DerefMut.
|
Will release the update tomorrow (it's midnight here in Ukraine 🙂). |
|
Merging the PRs, thanks! |
| @@ -21,18 +21,18 @@ open_url = ["webbrowser"] | |||
| default_fonts = ["egui/default_fonts"] | |||
|
|
|||
| [dependencies] | |||
| bevy = { version = "0.8", default-features = false, features = ["bevy_render", "bevy_core_pipeline", "bevy_asset"] } | |||
| bevy = { version = "0.9.0", default-features = false, features = ["bevy_render", "bevy_core_pipeline", "bevy_asset"] } | |||
There was a problem hiding this comment.
@mvlabat
Thanks for merging it! <3
btw; Is there a reason why the version is fixed to 0.9.0 instead of 0.9? :)
There was a problem hiding this comment.
Hi! No particular reason. In 0.9.0 behaves the same way as ^0.9.0 (and 0.9). If 0.9.1 is released, this won't prevent to install it.
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio
One of my projects has a rendering bug that is fixed on Bevy/main. Due to breaking changes in
0.9 dev, I couldn't use bevy_egui anymore. This PR adopts all the bevy changes required to run bevy_egui with the current state of bevy 0.9 dev. Not sure if you already want to merge it, but I wanted to share it already in case anybody else is in my situation.