/uboot-go

Detect and return errors from Open in case of malformed data #2

Merged
merged 1 commit into from May 16, 2017

Conversation

Reviewers

@mvo5 mvo5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zyga @mvo5
@zyga
Contributor

zyga commented May 16, 2017

The Open code relied on parseData which would panic if the data did
not conform to the key=value syntax. Since panicking is may not be
expected by the caller return an error instead.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com
@zyga
Detect and return errors from Open in case of malformed data 
The Open code relied on parseData which would panic if the data did
not conform to the key=value syntax. Since panicking is may not be
expected by the caller return an error instead.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
6d2bdd6
@mvo5

mvo5 approved these changes May 16, 2017
View changes

Thanks, looks great!

@mvo5 mvo5 merged commit 3e62d7f into mvo5:master May 16, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zyga zyga referenced this pull request in snapcore/snapd May 16, 2017

Merged

vendor,partition: fix panics from uenv #3325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment