/unattended-upgrades

Multiple fixes for issues reported to BTS and Launchpad #83

Merged
merged 32 commits into from Dec 21, 2017

Conversation

Reviewers

@mvo5 mvo5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rbalint @mvo5 @a-detiste @ChrisLeick
@rbalint
Collaborator

rbalint commented Dec 14, 2017

No description provided.

rbalint and others added some commits Oct 16, 2017

@rbalint
Test for running systemd on Debian, too, when applying workaround for it
fa159e1
@rbalint
Fix calling dh_installinit during build
81ac32f
@rbalint
Tidy up d/control using cme fix
f30f69e
@a-detiste @rbalint
Drop unused dependency on apt-utils 
Closes: #876425
18ad26f
@rbalint
Dutch translation update
d45b0b6
@ChrisLeick @rbalint
German translation update
cd8bf2b
@rbalint
Fix log file location in man page 
Thanks: Jaakov
Closes: #817974
7bca30c
@rbalint
Build-depend on debhelper (>= 9.20160709) instead of dh-systemd
a14b354
@rbalint
Link unattended-upgrades.8 to unattended-upgrade.8 man page
f74fdfc
@rbalint
Add Auto-Submitted header to email report 
LP: #1230246
2c2c381
@rbalint
Exit with error when package installation failed or u-u is signalled … 
…to stop

Closes: #838368
82e9eda
@rbalint
Process packages needing smaller upgrade sets earlier in generating m… 
…inimal upgrade sets

Inspired by Michael Vogt's partition pre-calculation code
f25ad41
@rbalint
Install upgrades from ${distro_codename}, label=Debian by default 
This enables updates from stable point releases but also lets testing
and sid being updated with the package updates.
Fixes #33.

Closes: #787945, #597061
e311522
@rbalint
Fix configuration file examples 
Closes: #877395
e68f774
@rbalint
Exit with printing error when apt errors prevent initialization 
LP: #1737442
177bbf4
@rbalint
Mark invalid UTF-8 characters in dpkg's log, but don't crash 
LP: #1737635
8ab04c4
@rbalint
Try upgrading packages replacing configuration dir with configuration… 
… file

LP: #1737637
9d430ce
@rbalint
Make unattended-upgrade-shutdown exit with error when apt config is i… 
…nvalid

LP: #1737717
2559da1
@rbalint
Exit when an apt error prevents checking a package for conffile prompt
1cc5b9b
@rbalint
Fix debian/NEWS.Debian's format
051d71e
@rbalint
Stop asking debconf question about Origins-Pattern 
50unattended-upgrades now contains multiple origins by default and setting
them from debconf can't be made really easy. Users should change the
configuration file itself instead.

LP: #1577215
bb867f9
@rbalint
Add NEWS item about unattended-uprades installing stable/all updates
b2d8489
@rbalint
Update PO files about debconf templates
a3b85c7
@rbalint
Don't log exceptions which did not happen
cdb5d30
@rbalint
Add autopkgtest for upgrading unstable between two snapshots from sna… 
…pshot.d.o
b21f665
@rbalint
Remove tabs from Debian's configuration file
6c52409
@rbalint
Update changelog
15c1483
@rbalint
Check in autopkgtest if unattended-upgrades mark additional packages … 
…as manually installed
6a73107
@rbalint
Test upgrading a full system with desktop packages in autopkgtest 
Also pick different shapshots with which does not contain
broken packages.
b2db2ba
@rbalint
Catch SystemError instead of apt_pkg.Error for backwards compatibility
669c048
@rbalint
Test sending email after upgrading a full system
b7ac300
debian/tests/upgrade-between-snapshots
@@ -16,7 +16,8 @@ case "$(lsb_release -s -i)" in
# install u-u to pull in dependencies and mark python3.5-minimal
# because otherwise u-u autoremoves it while running python3.5 code
chroot $chroot_dir apt-get install -y unattended-upgrades python3.5-minimal
- # TODO add a few interesting packages to upgrade
+ # add package set with many dependencies
+ chroot $chroot_dir apt-get install -y xfce4
@rbalint

rbalint Dec 14, 2017

Collaborator

This makes the test fail exposing https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875383

@mvo5

mvo5 approved these changes Dec 20, 2017
View changes

Nice! Tiny nitpick/question inside.

debian/tests/upgrade-between-snapshots
+
+set -e
+
+chroot_dir=$AUTOPKGTEST_TMP/chroot
@mvo5

mvo5 Dec 20, 2017

Owner

Nice test!

unattended-upgrade
@@ -504,15 +504,39 @@ def upgrade_in_minimal_steps(cache, # type: apt.Cache
# double check any changes we do
allowed_origins = get_allowed_origins()
+ # pre-calculate set sizes to process sets which are expected to be smaller
+ # earlier
+ upgrade_set_sizes = {}
@mvo5

mvo5 Dec 20, 2017

Owner

Won't this need a mypy type annotation?

@rbalint

rbalint Dec 21, 2017

Collaborator

I have not used mypy on this project but now trying it it reports several issues which I'll resolve in the next PR.
I'm also adding an annotation for this variable.

@mvo5

mvo5 Dec 21, 2017

Owner

Thanks! I added mypy hints a while ago, I thought I also added a corresponding test that is run in travis. Let me check what is going on there.

unattended-upgrade
pkg_conffiles = deb.control.extractdata("conffiles").strip().decode(
"utf-8")
+ except SystemError as e:
+ print(_("Apt returned an error, exiting"))
+ print(_("error message: '%s'") % e)
@mvo5

mvo5 Dec 20, 2017

Owner

Maybe remove this print and just raise again at the sys.exit(1) point?

@rbalint

rbalint Dec 21, 2017

Collaborator

For the users raising the issue would be as informative as printing it, but I'd like to avoid reporting known and handled errors to errors.ubuntu.com.

unattended-upgrade
@@ -759,6 +789,15 @@ def conffile_prompt(destFile, prefix=""):
# record for later
dpkg_status_conffiles[conf_file] = md5
+ # the package replaces a directory wih a configuration file
@mvo5

mvo5 Dec 20, 2017

Owner

Nice catch

@rbalint rbalint merged commit 43a717c into mvo5:master Dec 21, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment