Fix minor mistakes and typos #12

Merged
merged 11 commits into from Jul 22, 2012

Conversation

Projects
None yet
2 participants
Contributor

vhennebert commented Jul 17, 2012

This patch contains the following fixes:

  • Use the proper keyword to describe some commands (special form, function or macro);
  • Update the link to VimClojure;
  • Fix a minor style issue where code was not distinct from normal text when the browser disables custom fonts;
  • Fix other minor typos.

mvolkmann merged commit fe80350 into mvolkmann:master Jul 22, 2012

Owner

mvolkmann commented Jul 22, 2012

Thank you so much for your improvements to the article!
I have merged your pull request and am pushing a new version of the
article to the website right now.

On Tue, Jul 17, 2012 at 9:47 AM, Vincent Hennebert
reply@reply.github.com
wrote:

This patch contains the following fixes:

  • Use the proper keyword to describe some commands (special form, function or macro);
  • Update the link to VimClojure;
  • Fix a minor style issue where code was not distinct from normal text when the browser disables custom fonts;
  • Fix other minor typos.

You can merge this Pull Request by running:

git pull https://github.com/vhennebert/Clojure-Article master

Or you can view, comment on it, or merge it online at:

#12

-- Commit Summary --

  • Use monospace font instead of sans-serif for code
  • Update link to VimClojure
  • Replace dots with typographical ellipsis
  • doto is not a function, but a macro
  • def and let are not macros, but special forms
  • proxy is not a function, but a macro
  • dorun is not a macro, but a function
  • source is not a function, but a macro
  • Merge branch 'typos'
  • Fix minor typos
  • Merge remote-tracking branch 'upstream/master'

-- File Changes --

M article.html (69)

-- Patch Links --

https://github.com/mvolkmann/Clojure-Article/pull/12.patch
https://github.com/mvolkmann/Clojure-Article/pull/12.diff


Reply to this email directly or view it on GitHub:
#12

R. Mark Volkmann
Object Computing, Inc.

Contributor

vhennebert commented Jul 23, 2012

Thanks for applying my patch! However, there is now a problem displaying UTF-8 characters. Although the source file is encoded in UTF-8 the server sets the Content-Type field to 'text/html; charset=iso-8859-1' in the HTTP header.

Owner

mvolkmann commented Jul 23, 2012

Unfortunately I don't know what to do to address that. Do you know
what I should do?

On Mon, Jul 23, 2012 at 8:49 AM, Vincent Hennebert
reply@reply.github.com
wrote:

Thanks for applying my patch! However, there is now a problem displaying UTF-8 characters. Although the source file is encoded in UTF-8 the server sets the Content-Type field to 'text/html; charset=iso-8859-1' in the HTTP header.

R. Mark Volkmann
Object Computing, Inc.

Contributor

vhennebert commented Jul 26, 2012

Adding the line 'AddDefaultCharset UTF-8' to some config file should do. Depending on your setup, that config file could be the server's httpd.conf, or a .htaccess file in the same directory as the article.

HTH,
Vincent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment